Skip to content

Conversation

@crowning-
Copy link

  • Proposals now checked on the receiving end as well (see Security: sanitize mnbudget prepare|submit names and URLs #598)
  • Included the character "-" in "SanitizeString()" to be compatible with existing proposal names. If someone feels uncomfortable with this just tell me and I'll implement a different solution.
  • Implemented "mmbudget show " which was missing/only partly implemented.

@UdjinM6
Copy link

UdjinM6 commented Sep 12, 2015

re safeChars: ACK on adding dash 😉
it is definitely a safe one for URL http://www.rfc-editor.org/rfc/rfc1738.txt

Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
reserved characters used for their reserved purposes may be used
unencoded within a URL.

@schinzelh
Copy link

ACK - dash is a good choice :)

eduffield222 pushed a commit that referenced this pull request Sep 14, 2015
Security: sanitize mnbudget parameters (part 2) DASH-5
@eduffield222 eduffield222 merged commit f36e28e into dashpay:v0.12.1.x Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants