feat: drop hard-coded restrictions for platform-user #6105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
previously approved these changes
Jul 10, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
utACK 765294ce10e0bb83de94124e96ca0c65724303fd
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Jul 15, 2024
2db69d7 chore: add release notes for "quorum platformsign" (Konstantin Akimov) 283c5f8 feat: create new composite command "quorum platformsign" (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented It splits from #6100 With just whitelist it is impossible to limit the RPC `quorum sign` to use only one specific quorum type, this PR aim to provide ability for quorum signing for platform quorum only. ## What was done? Implemented a new composite command "quorum platformsign" This composite command let to limit quorum type for signing for case of whitelist. After that old way to limit platform commands can be deprecated - #6105 ## How Has This Been Tested? Updated a functional tests to use platform signing for Asset Unlocks feature. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 2db69d7 PastaPastaPasta: utACK 2db69d7 Tree-SHA512: b0dff9934137c4faa85664058e1e77f85067cc8d931e6d76ee5b9e610164ac8b0609736d5f09475256cb78d65bf92466624d784f0b13d20136df7e75613662cb
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2024
…msign 2db69d7 chore: add release notes for "quorum platformsign" (Konstantin Akimov) 283c5f8 feat: create new composite command "quorum platformsign" (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented It splits from dashpay#6100 With just whitelist it is impossible to limit the RPC `quorum sign` to use only one specific quorum type, this PR aim to provide ability for quorum signing for platform quorum only. ## What was done? Implemented a new composite command "quorum platformsign" This composite command let to limit quorum type for signing for case of whitelist. After that old way to limit platform commands can be deprecated - dashpay#6105 ## How Has This Been Tested? Updated a functional tests to use platform signing for Asset Unlocks feature. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 2db69d7 PastaPastaPasta: utACK 2db69d7 Tree-SHA512: b0dff9934137c4faa85664058e1e77f85067cc8d931e6d76ee5b9e610164ac8b0609736d5f09475256cb78d65bf92466624d784f0b13d20136df7e75613662cb
|
This pull request has conflicts, please rebase. |
…ists over Related changes for better support of whitelist for composite commands are in dashpay#6100
knst
force-pushed
the
drop-platform-user-hardcode
branch
from
765294c to
fcf143e
Compare
UdjinM6
approved these changes
Jul 19, 2024
PastaPastaPasta
requested changes
Aug 2, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
NACK for v21.1; while I find it incredibly unlikely anyone is using this, it is a public API and this would be a breaking change... As such, we should likely do a 2 cycle, deprecation followed by removal. In practice, I think taking into consideration the unlikely-ness that anyone is using this, and the fact that we can instead tell them to use rpcwhitelist to replicate functionality, I think it'll be okay to drop in v22. But not before then, also needs release notes :)
5 tasks
Collaborator
Author
|
Closed in favor of #6209 for v22. |
PastaPastaPasta
added a commit
that referenced
this pull request
Sep 27, 2024
…whitelist e2c66ae chore: deprecate a setting platform-user in favour of whitelist (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Hard-coded restrictions for platform-user are super-seeded by whitelist feature. ## What was done? Before actually removing feature, let's make it deprecated for now Split from #6105 6105 - to close and re-open for next major release. It deprecates old command line argument `-platform-user` by renaming to `-deprecated-platform-user` ## How Has This Been Tested? See new 2 functional tests: `rpc_deprecated_platform_filter.py` and `rpc_external_queue.py` which are split from `rpc_platform_filter.py` ## Breaking Changes Command line argument `-platform-user` is renamed to `-deprecated-platform-user` ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK e2c66ae PastaPastaPasta: utACK e2c66ae Tree-SHA512: c237065304f5ba682bc381a202a17e1b7191bb02ba5e51d8eec3170315ee980e0c20fd3b6aa6d77f75095c1761d374a7139ef289b0c78d74809b233f15a1a04a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
Hard-coded restrictions for platform-user are superseeded by whitelist feature.
Splits from #6100
How Has This Been Tested?
Run unit/functional tests
Breaking Changes
It deprecates old command line argument
-platform-userand special hard-coded logic related toplatform-userChecklist: