Skip to content

refactor: use new type of composite commands for governance NNN #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 7 commits into from
Jun 27, 2024
Merged

refactor: use new type of composite commands for governance NNN #6076

PastaPastaPasta merged 7 commits into from
Jun 27, 2024

Conversation

@knst
Copy link
Collaborator

@knst knst commented Jun 24, 2024

Issue being fixed or feature implemented

See #6051

What was done?

Commands starting from 'governance ...' uses new a new way to make composite commands.

This PR includes also a refactoring to remove common code between gobject list and gobject diff
This PR includes also a refactoring to properly use RPCHelpMan for remaining governance's RPC.

How Has This Been Tested?

Run unit/functional tests.

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 21 milestone Jun 24, 2024
@knst knst changed the title refactor: use new type of composite commands for governance NNN refactor: use new type of composite commands for governance NNN Jun 24, 2024
@knst knst requested review from PastaPastaPasta and UdjinM6 June 24, 2024 13:05
UdjinM6
UdjinM6 previously approved these changes Jun 24, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@github-actions
Copy link

github-actions bot commented Jun 25, 2024

This pull request has conflicts, please rebase.

@knst knst force-pushed the refactor-rpc-18531-p5 branch from 318f88c to c02ee94 Compare June 25, 2024 15:21
UdjinM6
UdjinM6 previously approved these changes Jun 25, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@github-actions
Copy link

github-actions bot commented Jun 27, 2024

This pull request has conflicts, please rebase.

@knst knst force-pushed the refactor-rpc-18531-p5 branch from c02ee94 to 91aae7b Compare June 27, 2024 19:13
UdjinM6
UdjinM6 approved these changes Jun 27, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 91aae7b

PastaPastaPasta
PastaPastaPasta approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 91aae7b

@PastaPastaPasta PastaPastaPasta merged commit f542e8e into dashpay:develop Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

21

Development

Successfully merging this pull request may close these issues.

3 participants

@knst @UdjinM6 @PastaPastaPasta