Skip to content

feat: Let addrman handle multiple ports for all networks #6062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 1 commit into from
Jun 18, 2024
Merged

feat: Let addrman handle multiple ports for all networks #6062

PastaPastaPasta merged 1 commit into from
Jun 18, 2024

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 15, 2024

Issue being fixed or feature implemented

There is really no need to do have this restriction in addrman, we check AllowMultiplePorts() in connman which should be enough already. We can safely re-align addrman to its upstream implementation as suggested in #6043.

What was done?

Drop port "discrimination" in addrman, remove related tests.

How Has This Been Tested?

Run tests, run dash-qt on mainnet/testnet

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 21 milestone Jun 15, 2024
@UdjinM6 UdjinM6 requested review from PastaPastaPasta, knst and kwvg June 15, 2024 09:47
kwvg
kwvg approved these changes Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 76b4300

PastaPastaPasta
PastaPastaPasta approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 76b4300; is it really a fix or a refactor? doesn't change observable system behavior

@UdjinM6
Copy link
Author

UdjinM6 commented Jun 15, 2024

It changes the internals of addrman logic so not a refactor imo. feat maybe?

@UdjinM6 UdjinM6 changed the title fix: Let addrman handle multiple ports for all networks feat: Let addrman handle multiple ports for all networks Jun 15, 2024
knst
knst approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 76b4300

@PastaPastaPasta PastaPastaPasta merged commit 7f17ff8 into dashpay:develop Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@kwvg kwvg kwvg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

21

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6 @knst @PastaPastaPasta @kwvg