Skip to content

Conversation

@knst
Copy link
Collaborator

@knst knst commented May 29, 2024

Latesst update 29th July 2025: https://github.com/dashpay/dash/actions/runs/16577153505/job/46884675000?pr=6038
Latest update 29th October 2024: https://gitlab.com/dashpay/dash/-/jobs/8212452793
Latest update 7th August 2024: https://gitlab.com/dashpay/dash/-/jobs/7761559496

Issue being fixed or feature implemented

It is a draft PR to test occasionally if ipv6 is fixed back on amazon's instances for our CI.
The IPv6 is not broken itself but CI fails: see #5988

What was done?

This reverts commit 0bb188a, reversing changes made to 45bdfa5 - Merge #5988: test: disable ipv6 tests for now

How Has This Been Tested?

Run CI

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (NO MILESTONE - until it doesn't work)

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Sep 5, 2024

Can you rebase this? see if it's fixed yet? Nevermind, did it for ya via GitHub. Will need a real rebase if we wanna merge obv

@github-actions
Copy link

This pull request has conflicts, please rebase.

@DashCoreAutoGuix
Copy link

❌ Backport Verification - Issues Detected

Original Bitcoin commit: N/A-REVERT (This PR reverts Dash commit 0bb188a)
Reviewed commit hash: ab8c6d61cd-verify-1737491200

Issues found:

  • CI failures: 2 build failures (GitHub Actions and GitLab CI)
  • Merge conflicts: PR needed rebase onto current develop branch
  • Authentication: Cannot push rebased changes due to verification mode permissions

Fix Applied (Manual Action Required):
I successfully resolved the merge conflict in test/functional/test_framework/netutil.py and rebased the PR onto the current develop branch. The conflict was resolved by choosing the PR's intent to re-enable IPv6 testing functionality.

Manual Steps to Complete:

  1. Someone with push permissions should force-push the rebased branch
  2. The rebased commit 73e9b55138 is ready and resolves the merge conflicts
  3. CI should be re-run after the push to verify IPv6 tests work on current infrastructure
❌ Changes Applied
diff --git a/test/functional/test_framework/netutil.py b/test/functional/test_framework/netutil.py
index 8431b9020e..43ac9060e6 100644
--- a/test/functional/test_framework/netutil.py
+++ b/test/functional/test_framework/netutil.py
@@ -146,12 +146,10 @@ def test_ipv6_local():
     '''
     # By using SOCK_DGRAM this will not actually make a connection, but it will
     # fail if there is no route to IPv6 localhost.
-    return False
-    # TODO: disabled until amazon ipv6 issues are resolved
-    # have_ipv6 = True
-    # try:
-    #     s = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
-    #     s.connect(('::1', 1))
-    # except socket.error:
-    #     have_ipv6 = False
-    # return have_ipv6
+    have_ipv6 = True
+    try:
+        s = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
+        s.connect(('::1', 1))
+    except socket.error:
+        have_ipv6 = False
+    return have_ipv6

Please rebase/force-push the resolved changes and re-run CI to test if IPv6 infrastructure is now working.
EOF < /dev/null

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

This reverts commit 0bb188a, reversing
changes made to 45bdfa5.
@knst knst force-pushed the fix-reenable-ipv6 branch from db2ba61 to a7d7170 Compare December 23, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants