-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: re-enable ipv6 tests #6038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Can you rebase this? see if it's fixed yet? Nevermind, did it for ya via GitHub. Will need a real rebase if we wanna merge obv |
02e9557 to
826c04e
Compare
826c04e to
98afd3e
Compare
98afd3e to
ab8c6d6
Compare
|
This pull request has conflicts, please rebase. |
❌ Backport Verification - Issues DetectedOriginal Bitcoin commit: Issues found:
Fix Applied (Manual Action Required): Manual Steps to Complete:
❌ Changes Applieddiff --git a/test/functional/test_framework/netutil.py b/test/functional/test_framework/netutil.py
index 8431b9020e..43ac9060e6 100644
--- a/test/functional/test_framework/netutil.py
+++ b/test/functional/test_framework/netutil.py
@@ -146,12 +146,10 @@ def test_ipv6_local():
'''
# By using SOCK_DGRAM this will not actually make a connection, but it will
# fail if there is no route to IPv6 localhost.
- return False
- # TODO: disabled until amazon ipv6 issues are resolved
- # have_ipv6 = True
- # try:
- # s = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
- # s.connect(('::1', 1))
- # except socket.error:
- # have_ipv6 = False
- # return have_ipv6
+ have_ipv6 = True
+ try:
+ s = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
+ s.connect(('::1', 1))
+ except socket.error:
+ have_ipv6 = False
+ return have_ipv6Please rebase/force-push the resolved changes and re-run CI to test if IPv6 infrastructure is now working. |
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
db2ba61 to
a7d7170
Compare
Latesst update 29th July 2025: https://github.com/dashpay/dash/actions/runs/16577153505/job/46884675000?pr=6038
Latest update 29th October 2024: https://gitlab.com/dashpay/dash/-/jobs/8212452793
Latest update 7th August 2024: https://gitlab.com/dashpay/dash/-/jobs/7761559496
Issue being fixed or feature implemented
It is a draft PR to test occasionally if ipv6 is fixed back on amazon's instances for our CI.
The IPv6 is not broken itself but CI fails: see #5988
What was done?
This reverts commit 0bb188a, reversing changes made to 45bdfa5 - Merge #5988: test: disable ipv6 tests for now
How Has This Been Tested?
Run CI
Breaking Changes
N/A
Checklist: