Skip to content

Conversation

@vijaydasmp
Copy link

bitcoin backports

@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin#22490, 22098 backport: Merge bitcoin#22490, 22098, 22496, 22597 May 15, 2024
@vijaydasmp vijaydasmp force-pushed the bp23_4 branch 2 times, most recently from 9474353 to 30f4382 Compare May 15, 2024 15:38
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin#22490, 22098, 22496, 22597 backport: Merge bitcoin#22490, 22098, 22496 May 15, 2024
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin#22490, 22098, 22496 backport: Merge bitcoin#22490, 22098, May 17, 2024
82b6f89 [style] Small style improvements to DNS parameters (Amiti Uttarwar)
4c89e24 [test] Test the delay before querying DNS seeds (Amiti Uttarwar)
6395c8e [test] Test the interactions between -forcednsseed and -dnsseed (Amiti Uttarwar)
6f6b7df [init] Disallow starting up with conflicting paramters for -dnsseed and -forcednsseed (Amiti Uttarwar)
26d0ffe [test] Test -forcednsseed causes querying DNS seeds (Amiti Uttarwar)
3585145 [test] Test the interactions between -connect and -dnsseed (Amiti Uttarwar)
75c05af [test] Test logic to query DNS seeds with block-relay-only connections (Amiti Uttarwar)
9c08719 [test] Introduce test logic to query DNS seeds (Amiti Uttarwar)

Pull request description:

  This PR adds a DNS seed to the regtest chain params to enable testing the DNS seed querying logic of `CConnman::ThreadDNSAddressSeed` and relevant startup parameters. Adds coverage for the changes in bitcoin#22013 (and then some).

  The main behavioral change to bitcoind is that this PR disallows starting up with conflicting parameters for `-dnsseed` and `-forcednsseed`.

  The tests include:
  * parameter interactions of different combinations of `-connect`, `-dnsseed` and `-forcednsseed`
  * the delay before querying DNS seeds depending on how many addresses are in the addrman
  * the behavior of `-forcednsseed`
  * skipping DNS querying if we have outbound full relay connections & not block-relay-only connections

  Huge props to mzumsande for identifying the timing technique for testing successful connections before running `ThreadDNSAddressSeed` 🙌🏽

ACKs for top commit:
  mzumsande:
    ACK 82b6f89
  jnewbery:
    reACK 82b6f89

Tree-SHA512: 9f0c29bfbf99426727e79c0a25606ae09deab91a92e3c5cee7f84c3ca7503a8ac9ab85a85c51841d40b164ef8c991326070f0b2f41d075fb7985df26f6e95d6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants