fix: revert "drop circular dependencies over deterministicmns in validationinterface" #5947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
In #5933, a commit was added that changed a copy to a ref in the arguments of a lambda (fa6847d), which helped get rid of a circular dependency. This unfortunately also caused a functional test to start failing (
interface_zmq_dash.py).This is reflected in the PR itself and in
developwith CI results:develop, as of this writing, a7e6111 (build, fails 3/4 instances)This change was also confirmed locally....
develop (a7e6111):
develop with revert (419a8af)
Breaking Changes
None. Fixes crash.
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.