ci: drop clang-diff-format.yml CI which does not seem useful #5942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significant part of our code is backported and we should follow bitcoin's codestyle Without extra tuning of clang-diff-format it does not have any value
5 tasks
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Apr 2, 2024
adc0e4b fix: apply changes for .clang-format to make it matched with our code style (Konstantin Akimov) 0c884f9 chore: narrow score of clang-diff-format for dash specific files only (Konstantin Akimov) 4bc0e1f chore: intentionally introducing wrong formatting to bip39.cpp to trigger CI (Konstantin Akimov) 2c74ad4 fix: adjust wallet/bip39 accordingly linter comments (Konstantin Akimov) d3faa85 refactor: use better masks for list of files; add missing bip39.{h,cpp} (Konstantin Akimov) 7788f1d refactor: move list of non backported files o test/util/data/non-backported.txt (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented **Note**: should be this PR either #5942 be merged, not both CI clang-format triggers to non-dash files + clang format is differ from out current formatting. ## What was done? See each commits ## How Has This Been Tested? See CI result To test locally how new style will look, just run this command: ``` diff -u <(cat {coinjoin,governance,llmq,evo,masternode}/*.{h,cpp}) <(clang-format-16 {coinjoin,governance,llmq,evo,masternode}/*.{h,cpp} ) ``` ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone Top commit has no ACKs. Tree-SHA512: d87f30ba78e04f886d7eb2b6b235c20a966bc4438e6428a83ecff5c795d72777516d4270eb9769ffebef9f06e9509acf3c535b4c87b1be6c8a5aef7e2b7efecb
|
This pull request has conflicts, please rebase. |
Collaborator
Author
|
DNM as #5949 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Note: should be this PR either #5949 be merged, not both
Significant part of our code is backported for bitcoin and we should follow bitcoin's codestyle for each particular line for each their implementation.
Without extra tuning and setup this CI doesn't have any value yet spam notification to emails.
Btw, the tool
contrib/devtools/clang-diff-format.pystill can be called locally to check if any blunder formatting such as 3 spaces.What was done?
Disabled ci
clang-diff-format.ymlHow Has This Been Tested?
Let's see this PR runned CIs.
Breaking Changes
N//A
Checklist: