refactor: move special transaction processing to helper, move C{CreditPool, NetFulfilledRequest}Manager to NodeContext, CDSTXManager to CJContext #5929

kwvg · 2024-03-10T11:55:52Z

Additional Information

Dependent on refactor: move masternode payments processing to helper class, move C{Governance,Spork}Manager to NodeContext #5908

Breaking Changes

None. Changes are limited to refactoring, no logical changes have been made.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas (note: N/A)
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation (note: N/A)
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

src/evo/specialtxman.cpp

src/test/util/setup_common.cpp

src/validation.h

knst · 2024-03-15T18:14:45Z

test/lint/lint-circular-dependencies.sh

it seems as validation.h is not needed in specialtxman

diff --git a/src/evo/specialtxman.cpp b/src/evo/specialtxman.cpp index 84a4f6afef..ffb1c3d5cb 100644 --- a/src/evo/specialtxman.cpp +++ b/src/evo/specialtxman.cpp @@ -17,7 +17,6 @@ #include <llmq/blockprocessor.h> #include <llmq/commitment.h> #include <primitives/block.h> -#include <validation.h> static bool CheckSpecialTxInner(const CTransaction& tx, const CBlockIndex* pindexPrev, const CCoinsViewCache& view, const std::optional<CRangesSet>& indexes, bool check_sigs, TxValidationState& state) {

Removing it causes the number of circular dependencies to explode

dash@1914d5152e74:/src/dash$ ./test/lint/lint-circular-dependencies.sh A new circular dependency in the form of "evo/assetlocktx -> validation -> evo/specialtxman -> evo/assetlocktx" appears to have been introduced. A new circular dependency in the form of "evo/cbtx -> validation -> evo/specialtxman -> evo/cbtx" appears to have been introduced. A new circular dependency in the form of "evo/chainhelper -> masternode/payments -> validation -> evo/chainhelper" appears to have been introduced. A new circular dependency in the form of "evo/creditpool -> validation -> evo/specialtxman -> evo/creditpool" appears to have been introduced. A new circular dependency in the form of "evo/deterministicmns -> validation -> evo/specialtxman -> evo/deterministicmns" appears to have been introduced. A new circular dependency in the form of "evo/mnhftx -> validation -> evo/specialtxman -> evo/mnhftx" appears to have been introduced. A new circular dependency in the form of "evo/specialtxman -> llmq/blockprocessor -> validation -> evo/specialtxman" appears to have been introduced. Good job! The circular dependency "evo/specialtxman -> validation -> evo/specialtxman" is no longer present. Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./test/lint/lint-circular-dependencies.sh to make sure this circular dependency is not accidentally reintroduced. Good job! The circular dependency "evo/chainhelper -> evo/specialtxman -> validation -> evo/chainhelper" is no longer present. Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./test/lint/lint-circular-dependencies.sh to make sure this circular dependency is not accidentally reintroduced.

I think that's ok. Still good to resolve any circulars we can. Getting rid of 1 big circular may result in many smaller circulars but 🤷‍♂️

It is as expected. These circulate dependencies have a longer path and they just had been hidden by the shorter one.

The logic of script shows only the shortest one and by removing it you won't introduce any new circular dependencies but quite opposite reveal already existing. That's expected and fine to have. They can be addressed now one by one.

The validation header was not added in this PR (see develop) so I'll remove the header and update circular dependencies in a separate PR, see #5941

knst · 2024-03-15T18:16:45Z

src/dsnotificationinterface.cpp

should dsnotificationinferface do assert? or just return enough? why assert?

If it is accessing (smart) pointers, IMO yes. We check the validity of a (smart) pointer in other parts of the codebase before trying to access them and so far, we've implicitly assumed that in the time between the interface initializing and the first call being made, the dependent contexts/managers have been initialized.

Adding an assertion would alert us to anything that contravenes that assumption by explicitly defining it. For something like BlockConnected, the first call is to a manager in m_llmq_ctx so if a BlockConnected call is made that contravenes the assumption, we'd know about it immediately.

The same doesn't hold true for UpdatedBlockTip, which has some fast-fail conditions until we reach a possibly affected call. This no longer becomes a problem if we explicitly define assertions.

Plus, the assertion serve as a one-liner that enumerates the (smart) pointers being relied on for the rest of the function.

knst · 2024-03-15T18:29:14Z

src/validation.h

Instead removing it is possible to move this method from CChainState to CChainStateHelper.

If do that, BlockAssembler can call chainstate_helper->GeetMNHFSignalsStage and no need to pass mnhfManager in constructor of BlockAssembler.

src/rpc/mining.cpp

src/init.cpp

As found in a review comment in dashpay#5908[1], validation.h is not needed for specialtxman.cpp and removing the header uncovers other circular dependencies that were obscured by the shortest circular path[2]. [1] - dashpay#5929 (comment) [2] - dashpay#5929 (comment)

knst

utACK 47de7deeb17af8c541284721e387231342d45acb

UdjinM6

🤯 😄
utACK

…ndencies dfddfd0 trivial: remove unneeded header, enumerate circular dependencies (Kittywhiskers Van Gogh) Pull request description: ## Additional Information As found in #5929 (comment), `validation.h` is not needed for `specialtxman.cpp` and removing the header uncovers other circular dependencies that were obscured by the shortest circular path (see #5929 (comment)). ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK dfddfd0 Tree-SHA512: c3e74c1a381c0b69985a29f57da3565ec7681548389f09ab8b9907386f0a9f221db92a39409eb46595f3546edffa389774b96b0c9dd8f4fedff46f2d3bd635f1

PastaPastaPasta · 2024-03-18T19:48:52Z

Please rebase: when trying to merge into develop I'm getting this

A new circular dependency in the form of "evo/chainhelper -> masternode/payments -> validation -> evo/chainhelper" appears to have been introduced.

Good job! The circular dependency "evo/chainhelper -> evo/specialtxman -> validation -> evo/chainhelper" is no longer present.
Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./test/lint/lint-circular-dependencies.sh
to make sure this circular dependency is not accidentally reintroduced.

github-actions · 2024-03-18T20:14:52Z

This pull request has conflicts, please rebase.

GetMNHFSignalsStage doesn't actually probe anything from CChainState nor is necessary for CChainState members.

We don't need to run `GetDSTX` in `HandleNewRecoveredSig` since we know for sure the transaction being handled is for enhanced hard forking

Decoupling initialization from loading the database means we need to assert if the database is actually loaded before performing any operations on it (i.e. check if the manager is "valid")

Co-authored-by: UdjinM6 <[email protected]>

PastaPastaPasta · 2024-03-19T00:44:26Z

I think the range-diff looks good

 -:  ---------- >  1:  f5642281cc Merge #20282: wallet: change upgradewallet return type to be an object
 -:  ---------- >  2:  19aba38cab Merge #19200: rpc: remove deprecated getaddressinfo fields
 -:  ---------- >  3:  9c54cb16de Merge #19405: rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo`
 -:  ---------- >  4:  86dd0eabb4 chore: increase amount of build jobs from 4 to 8 for depends
 -:  ---------- >  5:  58d923cd5b Merge #19528: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc)
 -:  ---------- >  6:  41c35fd8dc fix: adjust missing arguments and help for misc rpc: debug, echo, mnsync
 -:  ---------- >  7:  860d31f504 Merge #19455: rpc generate: print useful help and error message
 -:  ---------- >  8:  7ac1ee0fb4 Merge #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump)
 -:  ---------- >  9:  f525f574b0 fix: follow-up missing changes from Merge #18607: rpc: Fix named arguments in documentation
 -:  ---------- > 10:  c30c8f22dd Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction)
 -:  ---------- > 11:  af9eb81e56 fix: wrong name of arguments for RPC
 -:  ---------- > 12:  0e1a31159f Merge #19994: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
 -:  ---------- > 13:  d0163543d9 refactor: use new format CPCCommand for rpc/coinjoin
 -:  ---------- > 14:  b54f03a0c1 fix: wrong name of argument for coinjoin
 -:  ---------- > 15:  3621966f12 feat: add todo to drop Throw() from rpc/util.h
 -:  ---------- > 16:  c5031685bc fix: rename arguments for 'voteraw'
 -:  ---------- > 17:  dfddfd09a4 trivial: remove unneeded header, enumerate circular dependencies
 1:  40dcfce882 ! 18:  2dd6082e54 refactor: move special transaction processing into helper class
    @@ src/validation.h: public:
                                            const std::optional<uint256>& snapshot_blockhash = std::nullopt)
              EXCLUSIVE_LOCKS_REQUIRED(::cs_main);
      
    -
    - ## test/lint/lint-circular-dependencies.sh ##
    -@@ test/lint/lint-circular-dependencies.sh: EXPECTED_CIRCULAR_DEPENDENCIES=(
    -     "llmq/signing -> masternode/node -> validationinterface -> llmq/signing"
    -     "evo/mnhftx -> validation -> evo/mnhftx"
    -     "evo/deterministicmns -> validation -> evo/deterministicmns"
    --    "evo/chainhelper -> masternode/payments -> validation -> evo/chainhelper"
    -+    "evo/chainhelper -> evo/specialtxman -> validation -> evo/chainhelper"
    - )
    - 
    - EXIT_CODE=0
 2:  459fe7b4db = 19:  0d6f736a19 fix: add missing entity for destruction in DashTestSetupClose
 3:  00de06890f = 20:  667852c851 refactor: cleanup CDSNotificationInterface member names, add asserts
 4:  044b94fb69 ! 21:  67cfee70f8 refactor: remove CMNHFManager::GetSignalsStage alias from CChainState
    @@ src/rpc/blockchain.cpp
      
      #include <llmq/chainlocks.h>
      #include <llmq/instantsend.h>
    -@@ src/rpc/blockchain.cpp: UniValue getblockchaininfo(const JSONRPCRequest& request)
    -         },
    -     }.Check(request);
    +@@ src/rpc/blockchain.cpp: RPCHelpMan getblockchaininfo()
    +         [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
    + {
      
     -    ChainstateManager& chainman = EnsureAnyChainman(request.context);
     -    LOCK(cs_main);
    @@ src/rpc/mining.cpp: static UniValue generateBlocks(ChainstateManager& chainman,
              if (!pblocktemplate.get())
                  throw JSONRPCError(RPC_INTERNAL_ERROR, "Couldn't create new block");
              CBlock *pblock = &pblocktemplate->block;
    -@@ src/rpc/mining.cpp: static UniValue generatetodescriptor(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generatetodescriptor()
          ChainstateManager& chainman = EnsureChainman(node);
          LLMQContext& llmq_ctx = EnsureLLMQContext(node);
      
     -    return generateBlocks(chainman, *node.evodb, *node.chain_helper, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
     +    return generateBlocks(chainman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
    + },
    +     };
      }
    - 
    - static UniValue generatetoaddress(const JSONRPCRequest& request)
    -@@ src/rpc/mining.cpp: static UniValue generatetoaddress(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generatetoaddress()
      
          CScript coinbase_script = GetScriptForDestination(destination);
      
     -    return generateBlocks(chainman, *node.evodb, *node.chain_helper, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
     +    return generateBlocks(chainman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
    + },
    +     };
      }
    - 
    - static UniValue generateblock(const JSONRPCRequest& request)
    -@@ src/rpc/mining.cpp: static UniValue generateblock(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generateblock()
              LOCK(cs_main);
      
              CTxMemPool empty_mempool;
    @@ src/rpc/mining.cpp: static UniValue generateblock(const JSONRPCRequest& request)
              if (!blocktemplate) {
                  throw JSONRPCError(RPC_INTERNAL_ERROR, "Couldn't create new block");
              }
    -@@ src/rpc/mining.cpp: static UniValue getblocktemplate(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan getblocktemplate()
              // Create new block
              CScript scriptDummy = CScript() << OP_TRUE;
              LLMQContext& llmq_ctx = EnsureAnyLLMQContext(request.context);
 5:  fe57a46254 ! 22:  f0451fb98d refactor: remove CCreditPoolManager global, move to NodeContext
    @@ src/rpc/mining.cpp: static UniValue generateBlocks(ChainstateManager& chainman,
              if (!pblocktemplate.get())
                  throw JSONRPCError(RPC_INTERNAL_ERROR, "Couldn't create new block");
              CBlock *pblock = &pblocktemplate->block;
    -@@ src/rpc/mining.cpp: static UniValue generatetodescriptor(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generatetodescriptor()
          ChainstateManager& chainman = EnsureChainman(node);
          LLMQContext& llmq_ctx = EnsureLLMQContext(node);
      
     -    return generateBlocks(chainman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
     +    return generateBlocks(chainman, *node.cpoolman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
    + },
    +     };
      }
    - 
    - static UniValue generatetoaddress(const JSONRPCRequest& request)
    -@@ src/rpc/mining.cpp: static UniValue generatetoaddress(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generatetoaddress()
      
          CScript coinbase_script = GetScriptForDestination(destination);
      
     -    return generateBlocks(chainman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
     +    return generateBlocks(chainman, *node.cpoolman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
    + },
    +     };
      }
    - 
    - static UniValue generateblock(const JSONRPCRequest& request)
    -@@ src/rpc/mining.cpp: static UniValue generateblock(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generateblock()
              LOCK(cs_main);
      
              CTxMemPool empty_mempool;
    @@ src/rpc/mining.cpp: static UniValue generateblock(const JSONRPCRequest& request)
              if (!blocktemplate) {
                  throw JSONRPCError(RPC_INTERNAL_ERROR, "Couldn't create new block");
              }
    -@@ src/rpc/mining.cpp: static UniValue getblocktemplate(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan getblocktemplate()
              // Create new block
              CScript scriptDummy = CScript() << OP_TRUE;
              LLMQContext& llmq_ctx = EnsureAnyLLMQContext(request.context);
 6:  bfbc68513d = 23:  a53046c4a9 refactor: remove CDSTXManager global and alias, move to CJContext
 7:  f280fb8525 = 24:  c427305805 refactor: remove CNetFulfilledRequestManager global, move to NodeContext
 8:  47de7deeb1 ! 25:  991c9ec1a2 refactor: accept NodeContext arg into BlockAssembler instead of managers
    @@ src/rpc/mining.cpp: static UniValue generateBlocks(ChainstateManager& chainman,
              if (!pblocktemplate.get())
                  throw JSONRPCError(RPC_INTERNAL_ERROR, "Couldn't create new block");
              CBlock *pblock = &pblocktemplate->block;
    -@@ src/rpc/mining.cpp: static UniValue generatetodescriptor(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generatetodescriptor()
          const NodeContext& node = EnsureAnyNodeContext(request.context);
          const CTxMemPool& mempool = EnsureMemPool(node);
          ChainstateManager& chainman = EnsureChainman(node);
    @@ src/rpc/mining.cpp: static UniValue generatetodescriptor(const JSONRPCRequest& r
      
     -    return generateBlocks(chainman, *node.cpoolman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
     +    return generateBlocks(chainman, node, mempool, coinbase_script, num_blocks, max_tries);
    + },
    +     };
      }
    - 
    - static UniValue generatetoaddress(const JSONRPCRequest& request)
    -@@ src/rpc/mining.cpp: static UniValue generatetoaddress(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generatetoaddress()
          const NodeContext& node = EnsureAnyNodeContext(request.context);
          const CTxMemPool& mempool = EnsureMemPool(node);
          ChainstateManager& chainman = EnsureChainman(node);
    @@ src/rpc/mining.cpp: static UniValue generatetoaddress(const JSONRPCRequest& requ
      
     -    return generateBlocks(chainman, *node.cpoolman, *node.evodb, *node.chain_helper, *node.mnhf_manager, llmq_ctx, mempool, coinbase_script, num_blocks, max_tries);
     +    return generateBlocks(chainman, node, mempool, coinbase_script, num_blocks, max_tries);
    + },
    +     };
      }
    - 
    - static UniValue generateblock(const JSONRPCRequest& request)
    -@@ src/rpc/mining.cpp: static UniValue generateblock(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan generateblock()
              LOCK(cs_main);
      
              CTxMemPool empty_mempool;
    @@ src/rpc/mining.cpp: static UniValue generateblock(const JSONRPCRequest& request)
              if (!blocktemplate) {
                  throw JSONRPCError(RPC_INTERNAL_ERROR, "Couldn't create new block");
              }
    -@@ src/rpc/mining.cpp: static UniValue getblocktemplate(const JSONRPCRequest& request)
    +@@ src/rpc/mining.cpp: static RPCHelpMan getblocktemplate()
      
              // Create new block
              CScript scriptDummy = CScript() << OP_TRUE;

UdjinM6

re-utACK

PastaPastaPasta

utACK 991c9ec

fa6847d refactor: drop circular dependencies over deterministicmns in validationinterface (Konstantin Akimov) f8d1853 refactor: even more passing CDeterministicMNManager by ref (Kittywhiskers Van Gogh) d4aa891 refactor: more passing CDeterministicMNManager by ref (Kittywhiskers Van Gogh) e628d75 refactor: pass CDeterministicMNManager by ref to CJContext members (Kittywhiskers Van Gogh) d731f41 refactor: pass CDeterministicMNManager by ref to LLMQContext members (Kittywhiskers Van Gogh) 6bd23f4 refactor: pass CDeterministicMNManager by ref to CGovernanceManager (Kittywhiskers Van Gogh) 055dbba refactor: move GetListAtChainTip() calls out of llmq::utils::*, misc changes (Kittywhiskers Van Gogh) da39b73 refactor: move GetListAtChainTip() calls out of CGovernanceVote (Kittywhiskers Van Gogh) e9de972 refactor: move GetListAtChainTip() calls out of CGovernanceObject (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Dependent on #5929 ## Breaking Changes None. Changes are limited to refactoring, no logical changes have been made. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: (self) utACK fa6847d knst: utACK fa6847d Tree-SHA512: f1acf44bad25789d03c48788a3ac1807d7c553ee45164276ffa6f0dc39dc02e5d29d364469633aa84b341e8c4c13508e0e7a114de6e01fb624f256acfd97199b

kwvg added this to the 21 milestone Mar 11, 2024

This was referenced Mar 11, 2024

refactor: reduce CDeterministicMNManager globals use #5933

Merged

refactor: move masternode payments processing to helper class, move C{Governance,Spork}Manager to NodeContext #5908

Merged

kwvg force-pushed the deglob4 branch 2 times, most recently from b69d518 to 3f10001 Compare March 15, 2024 17:29

knst reviewed Mar 15, 2024

View reviewed changes

kwvg force-pushed the deglob4 branch from 3f10001 to 47de7de Compare March 17, 2024 18:58

kwvg marked this pull request as ready for review March 17, 2024 18:59

kwvg mentioned this pull request Mar 18, 2024

trivial: remove unneeded header, enumerate circular dependencies #5941

Merged

5 tasks

knst previously approved these changes Mar 18, 2024

View reviewed changes

kwvg requested review from PastaPastaPasta and UdjinM6 March 18, 2024 09:27

UdjinM6 previously approved these changes Mar 18, 2024

View reviewed changes

PastaPastaPasta added the needs rebase label Mar 18, 2024

github-actions bot added needs rebase and removed needs rebase labels Mar 18, 2024

kwvg and others added 8 commits March 18, 2024 21:36

refactor: move special transaction processing into helper class

2dd6082

fix: add missing entity for destruction in DashTestSetupClose

0d6f736

refactor: cleanup CDSNotificationInterface member names, add asserts

667852c

refactor: remove CMNHFManager::GetSignalsStage alias from CChainState

67cfee7

GetMNHFSignalsStage doesn't actually probe anything from CChainState nor is necessary for CChainState members.

refactor: remove CCreditPoolManager global, move to NodeContext

f0451fb

refactor: remove CDSTXManager global and alias, move to CJContext

a53046c

We don't need to run `GetDSTX` in `HandleNewRecoveredSig` since we know for sure the transaction being handled is for enhanced hard forking

refactor: remove CNetFulfilledRequestManager global, move to NodeContext

c427305

Decoupling initialization from loading the database means we need to assert if the database is actually loaded before performing any operations on it (i.e. check if the manager is "valid")

refactor: accept NodeContext arg into BlockAssembler instead of managers

991c9ec

Co-authored-by: UdjinM6 <[email protected]>

kwvg dismissed stale reviews from UdjinM6 and knst via 991c9ec March 18, 2024 21:45

kwvg force-pushed the deglob4 branch from 47de7de to 991c9ec Compare March 18, 2024 21:45

github-actions bot removed the needs rebase label Mar 18, 2024

kwvg requested review from PastaPastaPasta, UdjinM6 and knst and removed request for PastaPastaPasta March 18, 2024 21:46

UdjinM6 approved these changes Mar 19, 2024

View reviewed changes

PastaPastaPasta approved these changes Mar 19, 2024

View reviewed changes

PastaPastaPasta merged commit ada0cf2 into dashpay:develop Mar 19, 2024

refactor: move special transaction processing to helper, move C{CreditPool, NetFulfilledRequest}Manager to NodeContext, CDSTXManager to CJContext #5929

refactor: move special transaction processing to helper, move C{CreditPool, NetFulfilledRequest}Manager to NodeContext, CDSTXManager to CJContext #5929

Uh oh!

Conversation

kwvg commented Mar 10, 2024

Additional Information

Breaking Changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

knst Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

kwvg Mar 17, 2024

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta Mar 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knst Mar 17, 2024

Choose a reason for hiding this comment

Uh oh!

kwvg Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

knst Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

kwvg Mar 17, 2024

Choose a reason for hiding this comment

Uh oh!

knst Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta commented Mar 18, 2024

Uh oh!

github-actions bot commented Mar 18, 2024

Uh oh!

PastaPastaPasta commented Mar 19, 2024

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PastaPastaPasta Mar 17, 2024 •

edited

Loading