fix: ScanQuorums should not start cache population for outdated quorums #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
knst
reviewed
Dec 22, 2023
| assert(pQuorumBaseBlockIndex); | ||
| auto quorum = GetQuorum(llmqType, pQuorumBaseBlockIndex); | ||
| // populate cache for keepOldConnections most recent quorums only | ||
| bool populate_cache = vecResultQuorums.size() < llmq_params_opt->keepOldConnections; |
Collaborator
There was a problem hiding this comment.
is vecResultQuorum sorted from newest to oldest?
Author
There was a problem hiding this comment.
yes, the most recent quorum is at index 0
PastaPastaPasta
approved these changes
Dec 22, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
michal-zurkowski
added a commit
to michal-zurkowski/raptoreum
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Cache population for old quorums is a cpu heavy operation and should be avoided for inactive quorums at least oin
ScanQuorums. This issue is critical for testnet and other small network because every mn participate in almost every platform quorum and cache population for 2 months of quorums can easily block everything for 15+ minutes on a 4 cpu node. On mainnet quorum distribution is much better but it's still a small waste of cpu (or not so small for unlucky nodes).#5761 follow-up
What was done?
Do not start cache population for outdated quorums, improve logs in
StartCachePopulatorThreadto make it easier to see what's going on.How Has This Been Tested?
run a mn on testnet
Breaking Changes
n/a
Checklist: