Skip to content

docs: add v20.0.0 release notes, archive v19.3.0 and drop partial ones #5674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 5 commits into from
Nov 14, 2023
Merged

docs: add v20.0.0 release notes, archive v19.3.0 and drop partial ones #5674

PastaPastaPasta merged 5 commits into from
Nov 14, 2023

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Nov 5, 2023

Issue being fixed or feature implemented

NOTE: this PR is for v20.x branch, to be merged as the last one before v20 release.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Nov 5, 2023
thephez
thephez requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in draft, but here's a partial initial review

doc/release-notes.md Outdated
Copy link
Collaborator

@thephez thephez Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are no longer relevant for v20, right? (updated product brief: https://www.dash.org/blog/dashcore-v20-0-product-brief/)

doc/release-notes.md Outdated
Copy link
Collaborator

@thephez thephez Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer v20?

Copy link
Author

@UdjinM6 UdjinM6 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fully implemented and activated via v20 afaik

Copy link
Collaborator

@thephez thephez Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantics perhaps. I guess it's implemented, but not going to be used for anything on mainnet in v20? #5642

doc/release-notes.md Outdated
Copy link
Collaborator

@thephez thephez Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer v20

Copy link
Author

@UdjinM6 UdjinM6 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost the same, fully implemented but only "lock" part is activated in v20. Tweaked it a bit.

doc/release-notes.md Outdated
Copy link
Collaborator

@thephez thephez Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is meant by "verbal reject reason" 🤔 It returns a message but no error code?

Copy link
Author

@UdjinM6 UdjinM6 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's a copy-paste from doc/release-notes-17004.md

thephez
thephez requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more details

@PastaPastaPasta PastaPastaPasta mentioned this pull request Nov 13, 2023
Closed
47 tasks
@UdjinM6 UdjinM6 marked this pull request as ready for review November 13, 2023 16:35
thephez
thephez reviewed Nov 13, 2023
View reviewed changes
@UdjinM6
Copy link
Author

UdjinM6 commented Nov 13, 2023

squashed all the fixes and rebased

knst
knst reviewed Nov 13, 2023
View reviewed changes
knst
knst reviewed Nov 13, 2023
View reviewed changes
thephez
thephez requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a few more. I'm just going 🤪 looking at this.

PastaPastaPasta
PastaPastaPasta approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PastaPastaPasta PastaPastaPasta merged commit 3be7979 into dashpay:v20.x Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst left review comments

@thephez thephez thephez requested changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@ogabrielides ogabrielides Awaiting requested review from ogabrielides

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20

Development

Successfully merging this pull request may close these issues.

5 participants

@UdjinM6 @ogabrielides @knst @PastaPastaPasta @thephez