Skip to content

feat: reduce spamming logs with messages from v20 features #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 2 commits into from
Nov 6, 2023
Merged

feat: reduce spamming logs with messages from v20 features #5669

PastaPastaPasta merged 2 commits into from
Nov 6, 2023

Conversation

@knst
Copy link
Collaborator

@knst knst commented Nov 3, 2023 •
edited
Loading

Issue being fixed or feature implemented

There's too much spamming log items related to new v20 features: credit pool, asset locks, EHF manager, EHF Signaling for MN_RR.

Some logs are still spamming after this PR but related code is not changed here #5658

What was done?

  • Removed some log items, tidy-up other.
  • logs that supposed to appear for each block are moved to new categories EHF and CREDITPOOL

How Has This Been Tested?

Run unit/functional tests, reviewed log output

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

UdjinM6
UdjinM6 requested changes Nov 3, 2023
View reviewed changes
@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Nov 3, 2023

I think most of these should use LogPrint and not LogPrintf

@UdjinM6 UdjinM6 added this to the 20 milestone Nov 6, 2023
UdjinM6
UdjinM6 approved these changes Nov 6, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ogabrielides
ogabrielides approved these changes Nov 6, 2023
View reviewed changes
Copy link

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit cae3fa5 into dashpay:develop Nov 6, 2023
@knst knst mentioned this pull request Nov 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

+1 more reviewer

@ogabrielides ogabrielides ogabrielides approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20

Development

Successfully merging this pull request may close these issues.

4 participants

@knst @PastaPastaPasta @ogabrielides @UdjinM6