Skip to content

test: getblockchaininfo projected activation_height test #5665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 5 commits into from
Nov 6, 2023
Merged

test: getblockchaininfo projected activation_height test #5665

PastaPastaPasta merged 5 commits into from
Nov 6, 2023

Conversation

@ogabrielides
Copy link

@ogabrielides ogabrielides commented Nov 1, 2023 •
edited
Loading

Issue being fixed or feature implemented

#5640

What was done?

Tests that activation_height projected by getblockchaininfo during locked_in phase.
Now, this test is only possible with v20 activation since v19, dip0024 are buried and mn_rr uses MNEF.

Enabled this test only in feature_llmq_rotation.py.

How Has This Been Tested?

tests

Breaking Changes

no

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides marked this pull request as draft November 1, 2023 23:21
@ogabrielides ogabrielides added this to the 20 milestone Nov 2, 2023
@ogabrielides ogabrielides marked this pull request as ready for review November 2, 2023 12:57
PastaPastaPasta
PastaPastaPasta reviewed Nov 2, 2023
View reviewed changes
knst
knst reviewed Nov 3, 2023
View reviewed changes
knst
knst reviewed Nov 3, 2023
View reviewed changes
knst
knst reviewed Nov 3, 2023
View reviewed changes
@ogabrielides ogabrielides requested a review from knst November 3, 2023 14:58
@ogabrielides
Copy link
Author

ogabrielides commented Nov 3, 2023

Would need to rebase if #5668 gets merged first.

@ogabrielides ogabrielides mentioned this pull request Nov 3, 2023
Merged
5 tasks
knst
knst previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PastaPastaPasta
PastaPastaPasta previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

UdjinM6
UdjinM6 requested changes Nov 3, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see 208b4aa

@ogabrielides
Copy link
Author

ogabrielides commented Nov 3, 2023

pls see 208b4aa

makes sense

@ogabrielides ogabrielides dismissed stale reviews from PastaPastaPasta and knst via 6e563fb November 3, 2023 15:57
UdjinM6
UdjinM6 approved these changes Nov 4, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

knst
knst approved these changes Nov 4, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PastaPastaPasta PastaPastaPasta merged commit a612b31 into dashpay:develop Nov 6, 2023
@ogabrielides ogabrielides deleted the activation_height_test branch November 6, 2023 19:39
@ogabrielides ogabrielides mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20

Development

Successfully merging this pull request may close these issues.

4 participants

@ogabrielides @knst @UdjinM6 @PastaPastaPasta