test: fix feature_governance.py
#5657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
approved these changes
Oct 30, 2023
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
tested ACK
Without changes:
2023-10-30T18:02:05.954000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/home/knst/projects/dash/test/functional/test_framework/test_framework.py", line 155, in main
self.run_test()
File "/home/knst/projects/dash/test/functional/feature_governance.py", line 205, in run_test
payment_amounts_expected = [str(satoshi_round(str(p0_amount))), str(satoshi_round(str(p1_amount))), str(satoshi_round(str(p2_amount)))]
^^^^^^^^^
NameError: name 'p0_amount' is not defined
with changes:
2023-10-30T18:08:37.257000Z TestFramework (INFO): Tests successful
5 tasks
PastaPastaPasta
approved these changes
Oct 31, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
add missing
self.How Has This Been Tested?
run linter and
feature_governance.pyBreaking Changes
n/a
Checklist: