docs: Added release notes for #5262 #5558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: PastaPastaPasta <[email protected]>
thephez
requested changes
Aug 31, 2023
Co-authored-by: thephez <[email protected]>
thephez
approved these changes
Aug 31, 2023
UdjinM6
reviewed
Aug 31, 2023
Comment on lines
+6
to
+15
| Version 3 of Coinbase will include the following two fields: | ||
| - bestCLHeightDiff (uint32) | ||
| - bestCLSignature (BLSSignature) | ||
|
|
||
| bestCLSignature will hold the best Chainlock signature known at the moment of mining. | ||
| bestCLHeightDiff is equal to the diff in heights from the mined block height to the actual Chainlocked block height. | ||
|
|
||
| Although miners are forced to include a version 3 Coinbase, the actual real-time best Chainlock signature isn't required as long as blocks contain a bestCLSignature equal to (or newer than) the previous block. | ||
|
|
||
| Note: Until the first bestCLSignature is included in a Coinbase once v20 activates, null bestCLSignature and bestCLHeightDiff values are perfectly valid. |
There was a problem hiding this comment.
side note: we should update https://github.com/dashpay/dips/blob/master/dip-0004.md#coinbase-special-transaction with this info
Author
There was a problem hiding this comment.
Good point. Will open a PR for that.
Co-authored-by: UdjinM6 <[email protected]>
thephez
approved these changes
Aug 31, 2023
PastaPastaPasta
approved these changes
Sep 5, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
Added release notes for #5262.
How Has This Been Tested?
Breaking Changes
Checklist: