refactor: removed flag checkMalleable from bls's related code
#5462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Current implementation of BLS wrapper has an unclear interface related to
checkMalleableflag.There are 2 methods Unserialize, that has both default arguments:
Let's assume that I am calling
Unserialize(s, true)- it's very non-obvious which one will be called and not error prune at all.It should be re-implemented, and there should not be default argument.
Pasta noticed that this flag can be useful from performance point of view - let's have better new method such as
UnserializeNoMalleableor similar and use it when reindexing/etc. It should be specified explicit.Reverting this change and adding new interface in future won't be difficult task so far as changes are quite trivial.
What was done?
Removed flag checkMalleable to simplify code because it's always true.
It splits from #5443
How Has This Been Tested?
Run unit functional tests.
Breaking Changes
No breaking changes - flag is always true.
Checklist: