feat: mnlistdiff v20 CL sig quorums #5377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
added
RPC
knst
reviewed
May 18, 2023
UdjinM6
reviewed
May 18, 2023
|
This pull request has conflicts, please rebase. |
thephez
reviewed
May 18, 2023
Collaborator
thephez
left a comment
thephez
left a comment
There was a problem hiding this comment.
A few minor suggestions
|
This pull request has conflicts, please rebase. |
UdjinM6
requested changes
Jun 16, 2023
5 tasks
Co-authored-by: thephez <[email protected]>
Co-authored-by: UdjinM6 <[email protected]>
PastaPastaPasta
approved these changes
Jul 10, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Aug 16, 2023
Relates to dashpay/dash#5377
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Aug 30, 2023
* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Sep 27, 2023
* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Oct 3, 2023
Relates to dashpay/dash#5377
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Oct 3, 2023
* docs(rpc): update protx diff Relates to dashpay/dash#5377 * docs(rpc): add getindexinfo rpc Relates to dashpay/dash#5492 * docs(rpc): add gettxchainlocks Relates to dashpay/dash#5578 * docs(rpc): update getblock
5 tasks
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Nov 15, 2023
* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Nov 15, 2023
* docs(rpc): update protx diff Relates to dashpay/dash#5377 * docs(rpc): add getindexinfo rpc Relates to dashpay/dash#5492 * docs(rpc): add gettxchainlocks Relates to dashpay/dash#5578 * docs(rpc): update getblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Implementation of Randomness Beacon Part 3.
Starting from v20 activation fork, members for quorums are sorted using (if available) the best CL signature found in Coinbase.
If no CL signature is present yet, then the usual way is used (By using Blockhash instead)
The actual new way to shuffle is already implemented in #5366.
SPV clients also need to calculate members, but they only know block headers.
Since Coinbase is in the actual block, then they lack the required information to correctly calculate quorum members.
What was done?
MNLISTIDFFis enriched with a new fieldquorumsCLSigs. This field holds the Chainlock Signature required for each set of indexes corresponding to quorums in fieldnewQuorums.70230.70230will receive the new fieldquorumsCLSigs.protx diffRPC.Note:
quorumsCLSigswill populated only after v20 activationquorumsCLSigs.How Has This Been Tested?
70230.feature_llmq_rotation.pychecks thatquorumsCLSigsmatch in both P2P and RPC messages.Breaking Changes
No
Checklist: