Skip to content

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Apr 27, 2023

@PastaPastaPasta
Copy link
Member

Looks like there may be an issue with TSAN.. restarting that job to see if it's a once off

@UdjinM6
Copy link

UdjinM6 commented May 1, 2023

dropping 20942 "fixes" tsan build issue it seems

@github-actions
Copy link

github-actions bot commented May 9, 2023

This pull request has conflicts, please rebase.

@PastaPastaPasta PastaPastaPasta marked this pull request as draft May 9, 2023 17:09
@kwvg kwvg force-pushed the peermgr_refac branch from c10da1d to fd6e8eb Compare May 10, 2023 10:33
@kwvg kwvg changed the title backport: merge bitcoin#19791, #19911, #19910, #20217, #20649, #18458, #20811, #20942 (peer manager backports) backport: merge bitcoin#19791, #19911, #19910, #20217, #20649, #18458, #20811 (peer manager backports) May 10, 2023
@kwvg kwvg marked this pull request as ready for review May 10, 2023 10:36
@kwvg kwvg marked this pull request as draft May 10, 2023 11:56
@kwvg kwvg marked this pull request as ready for review May 10, 2023 11:58
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@kwvg kwvg requested review from UdjinM6 and knst May 10, 2023 12:51
@kwvg kwvg force-pushed the peermgr_refac branch from fd6e8eb to 5037d7f Compare May 11, 2023 09:06
@UdjinM6 UdjinM6 added this to the 20 milestone May 11, 2023
@kwvg kwvg requested review from PastaPastaPasta and UdjinM6 May 11, 2023 09:15
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta merged commit 11b64fc into dashpay:develop May 11, 2023
PastaPastaPasta pushed a commit that referenced this pull request May 26, 2023
…acktraces (#5375)

## Description

Pull request was inspired by the need to debug lock problems when
working on #5352.

As far as I'm aware, only macOS has `-Werror=thread-safety` as part of
its default `CXXFLAGS` despite the capability being present on Linux as
well. This PR introduces thread safety checks for that into our thread
sanitizer build.

Additionally, since we're using Clang, something that on first glimpse,
appears to be something that `stacktraces.cpp` isn't happy with, due to
`-Wl,-wrap` being available only on GCC, that no longer seems to be the
case, since the version of Clang with comes with `focal`, its `lld`
_does_ have support for `-wrap` (see [man page for `lld` on
`focal`](https://manpages.ubuntu.com/manpages/focal/en/man1/lld.1.html)).

The current `stable` version of Clang/LLVM is 15, at the time of this
pull request (see https://apt.llvm.org/) but `focal` ships with an older
version, requiring us to use the official LLVM APT repository. I feel we
should be testing with recent compilers alongside the ones shipped by
LTS distributions.

Certain bugs are only made apparent when testing on rolling release
distros or distros that have faster update cycles, like Fedora (see
#5295 for an illustration of that),
which ship with more recent compilers. Until we overhaul our CI systems
to test using those distros directly (our current infrastructure is
centered around using a "development image" with an LTS distro as the
base), this is the best we can do.

A similar pull request testing against the latest GCC stable will be
welcome as that is currently outside the scope of this PR as the changes
made were to make sure that builds were operating as expected on
Clang/LLVM 15.

---------

Co-authored-by: UdjinM6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants