Skip to content

Refactor/stackify all the things #5343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
PastaPastaPasta wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Refactor/stackify all the things #5343

PastaPastaPasta wants to merge 10 commits into from

Conversation

@PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Apr 21, 2023 •
edited
Loading

Before 227.80s user 48.84s system 97% cpu 4:42.30 total
After 229.49s user 49.36s system 98% cpu 4:43.40 total

Issue being fixed or feature implemented

Move items off the heap and to the stack when possible.

What was done?

Attempted to avoid all uses of std::vector where we know the size of the objects, instead using Span and std::array

How Has This Been Tested?

Reindexed testnet multiple times

Breaking Changes

Should be none

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@github-actions
Copy link

github-actions bot commented Jun 11, 2023

This pull request has conflicts, please rebase.

@PastaPastaPasta
Revert "build: stop tracking cmake dependency relic_conf.h.in"
f2fb5d4 
This reverts commit bc474e05f0b59d757d0fcf31adea9309b1ae7071.
@PastaPastaPasta
Merge commit '732855dff54972aa9c166883f7cb916bbcb12619' into bump-bls
b9a663a
@PastaPastaPasta
Merge commit '947fbdaf5f577f384fd0967d26b07664871678b4' into bump-bls
22d556a
@PastaPastaPasta
Merge commit '14b7599839f6c7376606a38f72bbbf2497c761b3' into bump-bls
49e97cc
@PastaPastaPasta
Merge commit 'b7e27fb8024f5f73d372b8751ac314c85a43fed1' into bump-bls
2c06763
@PastaPastaPasta
build: stop tracking cmake dependency relic_conf.h.in
1bb8a8c 
This reverts commit 4583ae1893cdb96613996ca700ffcb735595ae1c.
@PastaPastaPasta
refactor: use std::array instead of std::vector in tons of places!
c0feac0
@PastaPastaPasta
fixup
bc97862
@PastaPastaPasta
perf: avoid rehashing block; use stored hash
2df0624 
This saves ~2% of cycles on a reindex from 0-500000 on testnet
@PastaPastaPasta
minor fix
b458255
@PastaPastaPasta PastaPastaPasta force-pushed the refactor/stackify-all-the-things branch from de9efb5 to b458255 Compare June 14, 2023 18:40
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This pull request has conflicts, please rebase.

@coderabbitai coderabbitai bot mentioned this pull request Jan 10, 2025
Merged
5 tasks
@coderabbitai coderabbitai bot mentioned this pull request May 26, 2025
Merged
5 tasks
@DashCoreAutoGuix
Copy link

DashCoreAutoGuix commented Jul 28, 2025

❌ Backport Verification - Not Applicable

Original Bitcoin commit: N/A (this is not a Bitcoin backport)
Reviewed commit hash: b458255073-verify-$(date +%s)

Issues found:

  • This PR is original Dash development work, not a Bitcoin Core backport
  • The PR has unresolved merge conflicts that need to be addressed
  • No CI checks are running (likely due to conflicts)

Analysis:
This PR implements Dash-specific performance optimizations by converting std::vector usage to std::array and Span where possible. While this is valuable development work, it does not follow the Bitcoin backport process and should be reviewed using standard Dash development procedures.

Next Steps:

  1. Resolve the merge conflicts indicated by the bot comments
  2. Ensure CI checks pass after conflicts are resolved
  3. Have this reviewed as a standard Dash feature PR, not a backport

This verification system is designed for Bitcoin Core backports. For original Dash development, please follow the standard PR review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PastaPastaPasta @DashCoreAutoGuix