fix: hpmn adjustements to getprojectedmnpayees #5274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@PastaPastaPasta how about now? |
UdjinM6
requested changes
Mar 29, 2023
UdjinM6
reviewed
Mar 29, 2023
Author
|
@UdjinM6 What about now? |
UdjinM6
reviewed
Mar 29, 2023
PastaPastaPasta
approved these changes
Mar 30, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 30, 2023
## Issue being fixed or feature implemented `GetProjectedMNPayees` wasn't projecting MN payees correctly. ## What was done? HPMNs are now added 4 times before sorting the return list. In addition, the case of last payee being HPMN and having still pending payments is handled. ## How Has This Been Tested? Tested on Masternodes / Next Payment tab on Qt client on Testnet. ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
GetProjectedMNPayeeswasn't projecting MN payees correctly.What was done?
HPMNs are now added 4 times before sorting the return list.
In addition, the case of last payee being HPMN and having still pending payments is handled.
How Has This Been Tested?
Tested on Masternodes / Next Payment tab on Qt client on Testnet.
Breaking Changes
Checklist:
For repository code-owners and collaborators only