feat: isdlock support without quorum rotation (regtest only) #5259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
requested changes
Mar 16, 2023
| std::string strLLMQType = gArgs.GetArg("-llmqinstantsend", std::string(llmq_params_opt->name)); | ||
|
|
||
| Consensus::LLMQType llmqType = Consensus::LLMQType::LLMQ_NONE; | ||
| for (const auto& params : consensus.llmqs) { |
Collaborator
There was a problem hiding this comment.
nit: it seems as this loop already implemented several times:
if (auto optLLMQParams = ranges::find_if_opt(Params().GetConsensus().llmqs,
[&strLLMQType](const auto& params){return params.name == strLLMQType;})) {
in src/llmq/utils.cpp and src/chainparams.cpp:
Consensus::LLMQType llmqType = Consensus::LLMQType::LLMQ_NONE;
for (const auto& params : consensus.llmqs) {
if (params.name == strLLMQType) {
llmqType = params.type;
}
}
May be it's time to refactor to a new method:
const Consensus::LLMQParams& GetLLMQ(const std::string& llmqTypeName) const;
?
Author
|
@knst All your suggestions are valid. |
Author
|
@PastaPastaPasta @UdjinM6 Moved this to v19 as requested by @markin-io. |
PastaPastaPasta
approved these changes
Mar 20, 2023
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Oct 30, 2023
…enddip0024` (#5654) ## Issue being fixed or feature implemented This reverts #5636 and introduces 2 similar cmd-line/config params which are made specifically for regtest. Turned out Platform guys actually still need smth like that for local testing #5259. ## What was done? pls see individual commits ## How Has This Been Tested? run tests but we don't really have(/need?) tests for this. ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ cc @shumkov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In #5229, we disabled rotation when running a regtest with 3 nodes.
Instantsend were non-deterministic islocks.
This PR aims to make them deterministic for a 3-nodes regtest network (Platform dev environment).
What was done?
Added the possibility to overwrite
llmqinstantsendandllmqinstantsenddip0024.By starting a regtest with:
-llmqinstantsend=llmq_test-llmqinstantsenddip0024=llmq_test_instantsendInstantsend locks will be deterministic without running quorum rotation.
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only