refactor: implement c++23 inspired ToUnderlying #5210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see std::to_underlying and https://en.cppreference.com/w/cpp/types/underlying_type Then, we use this instead of static_casts for enums -> underlying type
PastaPastaPasta
force-pushed
the
refac/tounderlying
branch
from
d425747 to
36776d3
Compare
Member
Author
|
I'm really confused why this build fails... Please help 🙈 |
|
Member
Author
Oh 🙈 I'll do that tonight 😂 |
Collaborator
|
linter complains |
Member
Author
resolved |
Collaborator
|
utACK |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Avoid lots of static_cast's from enums to underlying types. Communicate intention better
What was done?
implement c++23 inspired ToUnderlying, then see std::to_underlying and https://en.cppreference.com/w/cpp/types/underlying_type; Then, we use this instead of static_casts for enums -> underlying type
How Has This Been Tested?
make check
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only