fix: governance should not lock mempool mutex even call GetTransaction #5175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetTransaction is indeed called deep inside but the nullptr is pass as a pointer to mempool. There is no used global mempool and GetTransaction do not use any other mempool if argument with pointer to mempol is empty.
2 tasks
PastaPastaPasta
approved these changes
Jan 31, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Previously noticed, that GetTransaction is called deep inside governance objects and it is true indeed.
But so far it is used
nullptras a mempol object instead any real mempool in GetTransaction and no usage of a global mempool or any other mempool, this locks are useless.This changes are important for mempool globalization.
What was done?
Removed LOCK for ::mempool.cs in governance's code
How Has This Been Tested?
Run unit/functional tests. Also done deglobalization of mempool to validate that governance indeed doesn't use global mempool implicit in #5169
Breaking Changes
No breaking changes
Checklist: