Skip to content

docs(rpc): added missing legacy rpc in help #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 5 commits into from
Jan 20, 2023
Merged

docs(rpc): added missing legacy rpc in help #5161

PastaPastaPasta merged 5 commits into from
Jan 20, 2023

Conversation

@ogabrielides
Copy link

@ogabrielides ogabrielides commented Jan 14, 2023 •
edited
Loading

Issue being fixed or feature implemented

Added the missing rpc in protx help.
Release notes can be found in #5137

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides added this to the 19 milestone Jan 14, 2023
@ogabrielides ogabrielides added the RPC Some notable changes to RPC params/behaviour/descriptions label Jan 14, 2023
thephez
thephez reviewed Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions...

ogabrielides and others added 3 commits January 14, 2023 17:07
@ogabrielides ogabrielides requested a review from thephez January 14, 2023 15:07
thephez
thephez previously approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

PastaPastaPasta
PastaPastaPasta previously approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

UdjinM6
UdjinM6 requested changes Jan 16, 2023
View reviewed changes
@ogabrielides ogabrielides dismissed stale reviews from PastaPastaPasta and thephez via 84156ac January 16, 2023 18:49
@ogabrielides ogabrielides requested a review from UdjinM6 January 16, 2023 18:49
UdjinM6
UdjinM6 approved these changes Jan 16, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 23544c9 into dashpay:develop Jan 20, 2023
@ogabrielides ogabrielides deleted the missing_protx_legacy_help branch January 20, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@thephez thephez thephez left review comments

Assignees

No one assigned

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

19

Development

Successfully merging this pull request may close these issues.

4 participants

@ogabrielides @UdjinM6 @PastaPastaPasta @thephez