Skip to content

Conversation

@ogabrielides
Copy link

@ogabrielides ogabrielides commented Jan 4, 2023

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides added this to the 19 milestone Jan 4, 2023
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions...

@ogabrielides ogabrielides requested a review from thephez January 4, 2023 19:08
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me now 👍 It would be nice to have a small mention of why this upgrade was made or what benefit it provides.

PastaPastaPasta pushed a commit that referenced this pull request Jan 20, 2023
## Issue being fixed or feature implemented
Added the missing rpc in `protx` help.
Release notes can be found in #5137

## What was done?

## How Has This Been Tested?

## Breaking Changes

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [x] I have made corresponding changes to the documentation

**For repository code-owners and collaborators only**
- [x] I have assigned this pull request to a milestone

Co-authored-by: thephez <[email protected]>
@ogabrielides ogabrielides requested a review from thephez January 26, 2023 12:06
@ogabrielides ogabrielides requested a review from thephez January 26, 2023 16:47
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these too?

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ogabrielides
Copy link
Author

@PastaPastaPasta @UdjinM6 Could you review this please?

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit c6bc337 into dashpay:develop Feb 6, 2023
@ogabrielides ogabrielides deleted the bls_upgrade_release_notes branch February 6, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants