-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: Release notes for BLS upgrade #5137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Release notes for BLS upgrade #5137
Conversation
thephez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions...
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
thephez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me now 👍 It would be nice to have a small mention of why this upgrade was made or what benefit it provides.
## Issue being fixed or feature implemented Added the missing rpc in `protx` help. Release notes can be found in #5137 ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone Co-authored-by: thephez <[email protected]>
thephez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these too?
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
thephez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
|
@PastaPastaPasta @UdjinM6 Could you review this please? |
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for squash merge
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only