refactor: introduce a python-like enumerate() method, and use it in block_reward_reallocation_tests.cpp #5059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
requested changes
Oct 22, 2022
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
pls see 35db267504
Also, is src/test/block_reward_reallocation_tests.cpp the only place where this could be useful?
Member
Author
|
No, I'm sure it could be useful in a plethora of places, but here was the location that made me think of this. I'll apply your commit soon, I had actually done those changes but forgot to push 🙈 |
PastaPastaPasta
force-pushed
the
util/enumerate
branch
from
e27e087 to
32bd6be
Compare
…s enumerate() method, and use it in block_reward_reallocation_tests.cpp
PastaPastaPasta
force-pushed
the
util/enumerate
branch
from
32bd6be to
5268c46
Compare
UdjinM6
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
I like being explicit where possible, and the lack of an
enumeratefunction in c++ has annoyed me for a while. This PR implements a enumerate() function that takes in an iterable object, and returns an tuple containing an iterator and a index. This can be decomposed using structured bindings. This makes code clearer and more readable, and should easily compile down to the same machine code based on my limited playing with it in godboltWhat was done?
How Has This Been Tested?
make check
Breaking Changes
n/a
Checklist:
For repository code-owners and collaborators only