Skip to content

backport: bitcoin#16240, #18923, #19277, #20016, #20671 (auxiliary backports: part 5) #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 9 commits into from
Jul 3, 2022
Merged

backport: bitcoin#16240, #18923, #19277, #20016, #20671 (auxiliary backports: part 5) #4830

PastaPastaPasta merged 9 commits into from
Jul 3, 2022

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented May 7, 2022 •
edited
Loading

@kwvg kwvg mentioned this pull request May 7, 2022
Merged
@kwvg kwvg force-pushed the auxiliary_ports branch from 7c8d464 to c1814a9 Compare May 7, 2022 20:05
@github-actions
Copy link

github-actions bot commented May 12, 2022

This pull request has conflicts, please rebase.

@kwvg kwvg force-pushed the auxiliary_ports branch from c1814a9 to f9c3c38 Compare May 13, 2022 12:42
@kwvg kwvg force-pushed the auxiliary_ports branch from f9c3c38 to 22c2c94 Compare May 17, 2022 17:27
@github-actions
Copy link

github-actions bot commented May 17, 2022

This pull request has conflicts, please rebase.

@kwvg kwvg force-pushed the auxiliary_ports branch from 22c2c94 to 4e438eb Compare May 17, 2022 17:29
@github-actions
Copy link

github-actions bot commented May 18, 2022

This pull request has conflicts, please rebase.

@kwvg kwvg force-pushed the auxiliary_ports branch from 4e438eb to 8fa55be Compare June 10, 2022 10:41
@kwvg kwvg marked this pull request as ready for review June 10, 2022 10:47
@kwvg kwvg force-pushed the auxiliary_ports branch from 8fa55be to 98f3700 Compare June 10, 2022 13:29
@kwvg kwvg changed the title merge bitcoin#15141, 15437, 19219: auxiliary backports backport: bitcoin#15141, #15437, #16240, #18923, #19219, #19277, #20016, #20671, #21694 (auxiliary backports) Jun 10, 2022
@kwvg kwvg requested review from PastaPastaPasta and UdjinM6 June 11, 2022 04:55
@kwvg kwvg force-pushed the auxiliary_ports branch from 98f3700 to c67073f Compare June 11, 2022 15:27
@kwvg kwvg changed the title backport: bitcoin#15141, #15437, #16240, #18923, #19219, #19277, #20016, #20671, #21694 (auxiliary backports) backport: bitcoin#15141, #15437, #16240, #18923, #19219, #19277, #20016, #20671 (auxiliary backports) Jun 11, 2022
@kwvg kwvg mentioned this pull request Jun 11, 2022
Merged
@kwvg kwvg force-pushed the auxiliary_ports branch 7 times, most recently from 4e3b151 to 40c27b6 Compare June 12, 2022 10:31
@kwvg kwvg force-pushed the auxiliary_ports branch from 186b48c to 6e85a7a Compare June 23, 2022 06:19
@kwvg kwvg requested a review from PastaPastaPasta June 23, 2022 06:22
@UdjinM6 UdjinM6 added this to the 18.1 milestone Jun 23, 2022
UdjinM6
UdjinM6 previously approved these changes Jun 23, 2022
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta previously approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 2, 2022

IMO let's merge https://github.com/dashpay/dash/pull/4880/commits first @UdjinM6

@github-actions
Copy link

github-actions bot commented Jul 2, 2022

This pull request has conflicts, please rebase.

@kwvg kwvg dismissed stale reviews from PastaPastaPasta and UdjinM6 via af2984b July 2, 2022 18:49
@kwvg kwvg force-pushed the auxiliary_ports branch from 6e85a7a to af2984b Compare July 2, 2022 18:49
@kwvg kwvg requested review from PastaPastaPasta and UdjinM6 July 2, 2022 18:51
UdjinM6
UdjinM6 approved these changes Jul 3, 2022
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

PastaPastaPasta
PastaPastaPasta approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta merged commit 87b6d1c into dashpay:develop Jul 3, 2022
@kwvg kwvg changed the title backport: bitcoin#15141, #15437, #16240, #18923, #19219, #19277, #20016, #20671 (auxiliary backports) backport: bitcoin#15141, #15437, #16240, #18923, #19219, #19277, #20016, #20671 (auxiliary backports: part 5) Sep 20, 2022
@kwvg kwvg changed the title backport: bitcoin#15141, #15437, #16240, #18923, #19219, #19277, #20016, #20671 (auxiliary backports: part 5) backport: bitcoin#15141, #15437, #16240, #18923, #19277, #20016, #20671 (auxiliary backports: part 5) Apr 7, 2024
@kwvg kwvg changed the title backport: bitcoin#15141, #15437, #16240, #18923, #19277, #20016, #20671 (auxiliary backports: part 5) backport: bitcoin#16240, #18923, #19277, #20016, #20671 (auxiliary backports: part 5) Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

+1 more reviewer

@HashEngineering HashEngineering HashEngineering left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.1

Development

Successfully merging this pull request may close these issues.

4 participants

@kwvg @UdjinM6 @PastaPastaPasta @HashEngineering