Merge bitcoin#14987 and bitcoin#14918 #4567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzutto
force-pushed
the
merge_14987_14918
branch
from
0965b81 to
4b5a541
Compare
dzutto
force-pushed
the
merge_14987_14918
branch
from
4b5a541 to
c4b2cd2
Compare
UdjinM6
requested changes
Nov 8, 2021
faa1522 RPCHelpMan: Pass through Result and Examples (MarcoFalke) Pull request description: Passing the rpc result and rpc examples through `RPCHelpMan` makes it clear in what order they appear in the stringified version. Future improvements could then autoformat or autogenerate them. Tree-SHA512: b32a5c178cc80f50a7e9b93a38e2b26d5994188ecafe9e61bbc599941b44b9b0e4e4be6413d4464fac6e8e73661a191a77d34917f2e6293de19fb59519dd4487
…mpile-time fa0ad4e RPCHelpMan: Check default values are given at compile-time (MarcoFalke) Pull request description: Remove the run time assertions on the default values and ensure that the correct default type and value is provided at compile time. Tree-SHA512: 80df2f3fab4379b500c773c27da63f22786c58be5963fe99744746320e43627a5d433eedf8b32209158df7805ebdce65ed4d242c829c4fe6e5d13deb4799ed42
Signed-off-by: Dzutte <[email protected]>
The new name should hopefully reflect the purpose of the function better. Signed-off-by: Dzutte <[email protected]>
dzutto
force-pushed
the
merge_14987_14918
branch
from
c4b2cd2 to
ed9cf45
Compare
UdjinM6
approved these changes
Nov 11, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
LGTM, utACK
TODO for future PRs: check all empty arg defaults and descriptions in Dash-specific RPCs and specify correct ones where it makes sense
PastaPastaPasta
approved these changes
Nov 13, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) wraps us the series of backports of changes related to RPCHelpMan and RPC documentation.