Skip to content

merge bitcoin#14150, #14477, #14646, #14667, #14886, #14565, #14491, #15368: descriptors #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 12 commits into from
Nov 1, 2021
Merged

merge bitcoin#14150, #14477, #14646, #14667, #14886, #14565, #14491, #15368: descriptors #4494

UdjinM6 merged 12 commits into from
Nov 1, 2021

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Oct 7, 2021 •
edited
Loading

@kwvg kwvg marked this pull request as draft October 7, 2021 15:43
@kwvg kwvg changed the title merge bitcoin#14150, #14477, #14646: descriptors merge bitcoin#14150, #14477, #14646, #14667, #14886, #14565, #14491, #15368: descriptors Oct 12, 2021
@kwvg kwvg marked this pull request as ready for review October 25, 2021 05:20
@kwvg kwvg force-pushed the descaddr branch 2 times, most recently from 7180e07 to 4651c6a Compare October 25, 2021 06:08
@github-actions
Copy link

github-actions bot commented Oct 25, 2021

This pull request has conflicts, please rebase.

@kwvg kwvg force-pushed the descaddr branch 2 times, most recently from 0d19f75 to 076d87c Compare October 26, 2021 16:31
UdjinM6
UdjinM6 requested changes Oct 26, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing few doc/release-notes-xxxxx.md files (which is probably ok) + see below

@kwvg kwvg requested a review from UdjinM6 October 28, 2021 07:53
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Oct 28, 2021
@UdjinM6
Copy link

UdjinM6 commented Oct 29, 2021

Looks good. 15749 should probably be marked as "partial" (missing changes to the code introduced in 14021).

PastaPastaPasta
PastaPastaPasta approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta mentioned this pull request Oct 29, 2021
Merged
UdjinM6
UdjinM6 approved these changes Nov 1, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit bbe9b3d into dashpay:develop Nov 1, 2021
@UdjinM6 UdjinM6 added this to the 18 milestone Nov 1, 2021
@kwvg kwvg deleted the descaddr branch July 18, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

Bitcoin Backport RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

4 participants

@kwvg @UdjinM6 @PastaPastaPasta @thephez