Merge bitcoin#14726: Use RPCHelpMan for all RPCs #4492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzutto
force-pushed
the
merge_14726
branch
2 times, most recently
from
8135398 to
21cc387
Compare
Merged
7 tasks
PastaPastaPasta
previously approved these changes
Oct 9, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
I didn't review or correctness, just for saftey, as in this PR only does what it says it does, and nothing more.
UdjinM6
requested changes
Oct 10, 2021
PastaPastaPasta
requested changes
Oct 11, 2021
UdjinM6
requested changes
Oct 11, 2021
fa5e045 rpc: Documentation fixups (MarcoFalke) fa91e8e Use RPCHelpMan for all RPCs (MarcoFalke) fa520e7 lint: Must use RPCHelpMan to generate the RPC docs (MarcoFalke) Pull request description: The resulting documentation should not change unless the type in the oneline-summary was previously incorrect. (E.g. string vs bool) Tree-SHA512: 4ff355b6a53178f02781e97a7aca7ee1d0d97ff348b6bf5a01caa1c96904ee33c704465fae54c2cd7445097427fd04c71ad3779bb7a7ed886055ef36c1b5a1d0
Signed-off-by: Dzutte <[email protected]>
PastaPastaPasta
approved these changes
Oct 11, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
* Merge bitcoin#14726: Use RPCHelpMan for all RPCs fa5e045 rpc: Documentation fixups (MarcoFalke) fa91e8e Use RPCHelpMan for all RPCs (MarcoFalke) fa520e7 lint: Must use RPCHelpMan to generate the RPC docs (MarcoFalke) Pull request description: The resulting documentation should not change unless the type in the oneline-summary was previously incorrect. (E.g. string vs bool) Tree-SHA512: 4ff355b6a53178f02781e97a7aca7ee1d0d97ff348b6bf5a01caa1c96904ee33c704465fae54c2cd7445097427fd04c71ad3779bb7a7ed886055ef36c1b5a1d0 * Dash-specific changes to support RPCHelpMan with RPC commands Signed-off-by: Dzutte <[email protected]> Co-authored-by: Wladimir J. van der Laan <[email protected]>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 17, 2023
* Merge bitcoin#14726: Use RPCHelpMan for all RPCs fa5e045 rpc: Documentation fixups (MarcoFalke) fa91e8e Use RPCHelpMan for all RPCs (MarcoFalke) fa520e7 lint: Must use RPCHelpMan to generate the RPC docs (MarcoFalke) Pull request description: The resulting documentation should not change unless the type in the oneline-summary was previously incorrect. (E.g. string vs bool) Tree-SHA512: 4ff355b6a53178f02781e97a7aca7ee1d0d97ff348b6bf5a01caa1c96904ee33c704465fae54c2cd7445097427fd04c71ad3779bb7a7ed886055ef36c1b5a1d0 * Dash-specific changes to support RPCHelpMan with RPC commands Signed-off-by: Dzutte <[email protected]> Co-authored-by: Wladimir J. van der Laan <[email protected]>
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* Merge bitcoin#14726: Use RPCHelpMan for all RPCs fa5e045 rpc: Documentation fixups (MarcoFalke) fa91e8e Use RPCHelpMan for all RPCs (MarcoFalke) fa520e7 lint: Must use RPCHelpMan to generate the RPC docs (MarcoFalke) Pull request description: The resulting documentation should not change unless the type in the oneline-summary was previously incorrect. (E.g. string vs bool) Tree-SHA512: 4ff355b6a53178f02781e97a7aca7ee1d0d97ff348b6bf5a01caa1c96904ee33c704465fae54c2cd7445097427fd04c71ad3779bb7a7ed886055ef36c1b5a1d0 * Dash-specific changes to support RPCHelpMan with RPC commands Signed-off-by: Dzutte <[email protected]> Co-authored-by: Wladimir J. van der Laan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.