partial Backport 18216 (warn sign-compare) #4491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
backport-warning
branch
from
e7e919f to
3ba3507
Compare
PastaPastaPasta
force-pushed
the
backport-warning
branch
from
3ba3507 to
36e5dc5
Compare
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
backport-warning
branch
from
36e5dc5 to
388db5a
Compare
|
This pull request has conflicts, please rebase. |
6853727 build: Enable -Werror=sign-compare (Ben Woosley) eac6a30 refactor: Rework asmap Interpret to avoid ptrdiff_t (Ben Woosley) df37377 test: Fix outstanding -Wsign-compare errors (Ben Woosley) Pull request description: Disallowing sign-comparison mismatches can help to prevent the introduction of overflow and interpretation bugs. In this case, ~all~ most existing violations are in the tests, and most simply required annotating the literal as unsigned for comparison. This was previously prevented by violations in leveldb which were fixed upstream and merged in bitcoin#17398. You can test that by building this branch against: 22d1118 vs 75fb37c ACKs for top commit: fjahr: re-ACK 6853727 practicalswift: ACK 6853727 Tree-SHA512: 14b5daa38c496fb51548feb30fb4dd179e6f76a8d355f52bc8e2a18f2f9340f0bc98dcf36d8b3d6521045d013891c3103749a4eda88ceef00202a6a0cf93f73c
PastaPastaPasta
force-pushed
the
backport-warning
branch
from
388db5a to
17a8497
Compare
Signed-off-by: pasta <[email protected]>
|
This Pull Request may conflict if the Pull Requests below are merged first. #4649 |
This was referenced Dec 30, 2021
|
This Pull Request may conflict if the Pull Requests below are merged first. #4650 |
|
This pull request has conflicts, please rebase. |
Collaborator
|
superseeded by #5722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this might depend on bitcoin 18750