Skip to content

Conversation

@vijaydasmp
Copy link

No description provided.

@vijaydasmp
Copy link
Author

This is Work in Progress

@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_1 branch from 68c7922 to 1357c6f Compare October 12, 2021 02:03
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_1 branch from e28f1ab to 7e17d80 Compare October 14, 2021 01:48
@vijaydasmp
Copy link
Author

feature_llmq_is_cl_conflicts.py is failing , will check why

@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_1 branch from 7e17d80 to b3a1041 Compare October 14, 2021 09:26
@vijaydasmp vijaydasmp requested a review from UdjinM6 October 14, 2021 09:27
MarcoFalke and others added 3 commits October 16, 2021 06:23
fa292ad doc: rpc-mining: Clarify error messages (MarcoFalke)

Pull request description:

  Fixes bitcoin#13274

ACKs for commit fa292a:
  fanquake:
    tACK fa292ad

Tree-SHA512: 58946a52ce49b97c35cbf5eaa9175447a231690cb2bac0d39e5db524bdf2cbad274a905038aca270c080d5660f58176d43c01a22a8417c0f5b8276816939c1d6
1a7ba84 Fix lack of warning of unrecognized section names (Akio Nakamura)

Pull request description:

  In bitcoin#14708, It was introduced that to warn when unrecognized section names are exist in the config file.
  But ```m_config_sections.clear()```  in ```ArgsManager::ReadConfigStream()``` is called every time when reading each configuration file, so it can warn about only last reading file if ```includeconf``` exists.

  This PR fix lack of warning by collecting all section names by moving ```m_config_sections.clear()```  to ```ArgsManager::ReadConfigFiles()``` .
  Also add a test code to confirm this situation.

Tree-SHA512: 26aa0cbe3e4ae2e58cbe73d4492ee5cf465fd4c3e5df2c8ca7e282b627df9e637267af1e3816386b1dc6db2398b31936925ce0e432219fec3a9b3398f01e3e65
947f73c [docs] remove reference to signrawtransaction in the developer docs. (John Newbery)
7b6616b [rpc] Remove deprecated functionality message from validateaddress help (John Newbery)
839c3f7 [rpc] Remove signrawtransaction warning (John Newbery)

Pull request description:

  Removes some deprecated code from the RPCs:

  - signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning message was left in place to advise users to use signrawtransactionwithwallet and signrawtransactionwithkey. That warning can now be removed.
  - validateaddress had some functionality deprecated in 0.17 and removed in 0.18. The help text for that functionality was not removed in 0.18 and can be removed now.

Tree-SHA512: 981678a697954ff2c392752e5a183b4b12c4eb94f55766ee1aa97a70d300668237db8fc5748c2772869d0155ba4a93e38817887b98160ee972a6f6ee94e3f7d9
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_1 branch 8 times, most recently from ca0c5df to 54731eb Compare October 16, 2021 15:32
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should drop 15765 + see below

MarcoFalke and others added 2 commits October 20, 2021 05:05
03d6d23 [tests] make pruning test faster (John Newbery)
1c29ac4 [tests] style fixes in feature_pruning.py (John Newbery)

Pull request description:

  This commit makes the pruning.py much faster.

  Key insights to do this:

  - pruning.py doesn't care what kind of transactions make up the big
  blocks that are pruned in the test. Instead of making blocks with
  several large, expensive to construct and validate transactions,
  instead make the large blocks contain a single coinbase transaction with
  a huge OP_RETURN txout.
  - avoid stop-starting nodes where possible.

ACKs for commit 03d6d2:
  MarcoFalke:
    utACK 03d6d23

Tree-SHA512: 511642ce0fa294319dce3486fe06d75970d8ab66deda7f692be081d3056b4ce5b4cf91a7b5762eefbba224ba6c848750016454ff1e5d564acc507b1c41213628
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_1 branch from 459498b to 946d879 Compare October 19, 2021 23:44
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_1 branch 4 times, most recently from fe9f805 to 2366480 Compare October 20, 2021 17:39
@UdjinM6 UdjinM6 added this to the 18 milestone Oct 20, 2021
@UdjinM6 UdjinM6 marked this pull request as ready for review October 20, 2021 23:33
@vijaydasmp vijaydasmp requested a review from UdjinM6 October 21, 2021 00:50
@vijaydasmp vijaydasmp changed the title Backport v19 vijay batch 1 merge bitcoin#15685,#15335,#15642,#15686,#15629 Oct 21, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

@PastaPastaPasta PastaPastaPasta merged commit 6e32a46 into dashpay:develop Oct 21, 2021
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Nov 3, 2021
@vijaydasmp vijaydasmp deleted the backport_v19_vijay_batch_1 branch December 29, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants