-
Notifications
You must be signed in to change notification settings - Fork 1.2k
merge bitcoin#15685,#15335,#15642,#15686,#15629 #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge bitcoin#15685,#15335,#15642,#15686,#15629 #4484
Conversation
|
This is Work in Progress |
68c7922 to
1357c6f
Compare
e28f1ab to
7e17d80
Compare
|
feature_llmq_is_cl_conflicts.py is failing , will check why |
7e17d80 to
b3a1041
Compare
fa292ad doc: rpc-mining: Clarify error messages (MarcoFalke) Pull request description: Fixes bitcoin#13274 ACKs for commit fa292a: fanquake: tACK fa292ad Tree-SHA512: 58946a52ce49b97c35cbf5eaa9175447a231690cb2bac0d39e5db524bdf2cbad274a905038aca270c080d5660f58176d43c01a22a8417c0f5b8276816939c1d6
1a7ba84 Fix lack of warning of unrecognized section names (Akio Nakamura) Pull request description: In bitcoin#14708, It was introduced that to warn when unrecognized section names are exist in the config file. But ```m_config_sections.clear()``` in ```ArgsManager::ReadConfigStream()``` is called every time when reading each configuration file, so it can warn about only last reading file if ```includeconf``` exists. This PR fix lack of warning by collecting all section names by moving ```m_config_sections.clear()``` to ```ArgsManager::ReadConfigFiles()``` . Also add a test code to confirm this situation. Tree-SHA512: 26aa0cbe3e4ae2e58cbe73d4492ee5cf465fd4c3e5df2c8ca7e282b627df9e637267af1e3816386b1dc6db2398b31936925ce0e432219fec3a9b3398f01e3e65
947f73c [docs] remove reference to signrawtransaction in the developer docs. (John Newbery) 7b6616b [rpc] Remove deprecated functionality message from validateaddress help (John Newbery) 839c3f7 [rpc] Remove signrawtransaction warning (John Newbery) Pull request description: Removes some deprecated code from the RPCs: - signrawtransaction was deprecated in 0.17 and removed in 0.18. A warning message was left in place to advise users to use signrawtransactionwithwallet and signrawtransactionwithkey. That warning can now be removed. - validateaddress had some functionality deprecated in 0.17 and removed in 0.18. The help text for that functionality was not removed in 0.18 and can be removed now. Tree-SHA512: 981678a697954ff2c392752e5a183b4b12c4eb94f55766ee1aa97a70d300668237db8fc5748c2772869d0155ba4a93e38817887b98160ee972a6f6ee94e3f7d9
ca0c5df to
54731eb
Compare
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should drop 15765 + see below
03d6d23 [tests] make pruning test faster (John Newbery) 1c29ac4 [tests] style fixes in feature_pruning.py (John Newbery) Pull request description: This commit makes the pruning.py much faster. Key insights to do this: - pruning.py doesn't care what kind of transactions make up the big blocks that are pruned in the test. Instead of making blocks with several large, expensive to construct and validate transactions, instead make the large blocks contain a single coinbase transaction with a huge OP_RETURN txout. - avoid stop-starting nodes where possible. ACKs for commit 03d6d2: MarcoFalke: utACK 03d6d23 Tree-SHA512: 511642ce0fa294319dce3486fe06d75970d8ab66deda7f692be081d3056b4ce5b4cf91a7b5762eefbba224ba6c848750016454ff1e5d564acc507b1c41213628
459498b to
946d879
Compare
fe9f805 to
2366480
Compare
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for merging via merge commit
No description provided.