Backport 0.18 PRs #14451, #14686, #14564, #14568,#15063, #15411: deprecate BIP70 and build GUI without BIP70 support #4350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzutto
changed the title
dzutto
force-pushed
the
backport_14451_14686_14564_15063_15411
branch
from
1679941 to
4f69970
Compare
UdjinM6
requested changes
Aug 19, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
pls see UdjinM6@886d259 and UdjinM6@83ce83e
dzutto
force-pushed
the
backport_14451_14686_14564_15063_15411
branch
from
4f69970 to
6ca3378
Compare
dzutto
commented
Aug 19, 2021
PastaPastaPasta
requested changes
Aug 22, 2021
src/Makefile.am
Outdated
Member
There was a problem hiding this comment.
14451: this should be reverted
dzutto
force-pushed
the
backport_14451_14686_14564_15063_15411
branch
from
6ca3378 to
5a52760
Compare
PastaPastaPasta
previously approved these changes
Aug 23, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
|
This pull request has conflicts, please rebase. |
Member
|
@dzutte-cpp Please don't merge develop into your branch, instead, rebase on develop. LMK if you need help |
Author
Sure, will do. |
dzutto
force-pushed
the
backport_14451_14686_14564_15063_15411
branch
2 times, most recently
from
251a1f7 to
a5d858f
Compare
|
This pull request has conflicts, please rebase. |
… GUI without BIP70 support 48439b3 Don't link SSL_LIBS with GUI unless BIP70 is enabled (James Hilliard) fbb643d Add BIP70 deprecation warning (James Hilliard) 38b9850 qt: cleanup: Move BIP70 functions together in paymentserver (Wladimir J. van der Laan) 9dcf6c0 build: Add --disable-bip70 configure option (Wladimir J. van der Laan) Pull request description: This is based off of bitcoin#11622 and adds a deprecation warning when a BIP70 URL is used. Rational: - BIP70 increases attack surface in multiple ways and is difficult for third party wallets to implement in a secure manner - Very few merchants use the standard BIP70 variant supported by Bitcoin Core - The one major payment processor that doesn't support BIP21 and currently uses a customized non-standard version of BIP70 has indicated that "Unfortunately the original BIP70 is not useful for us." Tree-SHA512: 1e16ee8d2cdac9499f751ee7b50d058278150f9e38a87a47ddb5105dd0353cdedabe462903f54ead6209b249b249fe5e6a10d29631531be27400f2f69c25b9b9
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee) Pull request description: See bitcoin#14451 (comment) Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
7a90b1b build: Fix windows build error if `--disable-bip70` (Chun Kuan Lee) Pull request description: Fix bitcoin#14677 The SSL library seems to be used even if bip70 disabled on Windows. Tree-SHA512: 1c5fcf98048ce9e2eedf958326c11949eef74b3379a50d73751cb871d3d4323186caf607888c461a1fe1edc5f8515bd151ab247a843e7dda79f810c06309bd88
…when protobuf is missing instead of the GUI 58c5cc9 Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (James Hilliard) Pull request description: This change ensures that the GUI is still built even if protobuf is missing unless --enable-bip70 is passed to configure. If protobuf is present bip70 support will be compiled in unless --disable-bip70 is passed. Tree-SHA512: 432d2fbefec5436503d8aa8994e4efaf760d88bfd5249af031b502b356852e8fd56362f86420f9ffe78498649079d0f1b68c327960b215d83c275800626ad275
…to BIP21 parsing 84f5315 Travis: Add test without BIP70 (but still full wallet + tests) (Luke Dashjr) 113f000 GUI: If BIP70 is disabled, give a proper error when trying to open a payment request file (Luke Dashjr) 9975282 GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (Luke Dashjr) Pull request description: Tree-SHA512: 66a684ce4336d0eac8b0107b405ff3a2cf312258a967f3e1b14734cd39db11e2db3e9b03492755583170d94d54754ef536b0776e5f19a0cc2caca8379eeb4495
dzutto
force-pushed
the
backport_14451_14686_14564_15063_15411
branch
from
a5d858f to
3480bfa
Compare
dzutto
force-pushed
the
backport_14451_14686_14564_15063_15411
branch
from
3480bfa to
2048e40
Compare
eeeee58 travis: Combine --disable-bip70 into existing job (MarcoFalke) Pull request description: We already have too many jobs, so instead of creating a separate job for the `--disable-bip70` configue option, combine it into an existing job Tree-SHA512: 9e2fae73d90cb55b588c545bc118a14eba064f17fffd9b302c3fdbb8715e2319db03eac92ae51b3c16481f28a004a1c964dab75ca80a213e87574da8f73e3207
PastaPastaPasta
approved these changes
Aug 29, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.