Skip to content

Conversation

@5tefan
Copy link

@5tefan 5tefan commented Aug 9, 2021

fa091b0 qa: Add tests for submitheader (MarcoFalke)
36b1b63 rpc: Expose ProcessNewBlockHeaders (MarcoFalke)

Pull request description:

This exposes ProcessNewBlockHeaders as an rpc called submitheader.
This can be used to check for invalid block headers and submission of
valid block headers via the rpc.

Tree-SHA512:
a61e850470f15465f88e450609116df0a98d5d9afadf36b2033d820933d8b6a4012f9f2b3246319c08a0e511bef517f5d808cd0f44ffca91d10895a938004f0b

Note: small deviation in functional test to deal with extra chaintips fields provided by Dash.

fa091b0 qa: Add tests for submitheader (MarcoFalke)
36b1b63 rpc: Expose ProcessNewBlockHeaders (MarcoFalke)

Pull request description:

  This exposes `ProcessNewBlockHeaders` as an rpc called `submitheader`.
This can be used to check for invalid block headers and submission of
valid block headers via the rpc.

Tree-SHA512:
a61e850470f15465f88e450609116df0a98d5d9afadf36b2033d820933d8b6a4012f9f2b3246319c08a0e511bef517f5d808cd0f44ffca91d10895a938004f0b
@5tefan 5tefan requested a review from UdjinM6 August 10, 2021 05:52
@UdjinM6 UdjinM6 added this to the 18 milestone Aug 10, 2021
@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Aug 10, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 97b3ad1 into dashpay:develop Aug 10, 2021
@5tefan 5tefan deleted the backports_018_b5591ca0b branch August 12, 2021 06:12
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 4, 2022
* Merge bitcoin#13399: rpc: Add submitheader

fa091b0 qa: Add tests for submitheader (MarcoFalke)
36b1b63 rpc: Expose ProcessNewBlockHeaders (MarcoFalke)

Pull request description:

  This exposes `ProcessNewBlockHeaders` as an rpc called `submitheader`.
This can be used to check for invalid block headers and submission of
valid block headers via the rpc.

Tree-SHA512:
a61e850470f15465f88e450609116df0a98d5d9afadf36b2033d820933d8b6a4012f9f2b3246319c08a0e511bef517f5d808cd0f44ffca91d10895a938004f0b

* Update test/functional/mining_basic.py

Co-authored-by: UdjinM6 <[email protected]>

Co-authored-by: UdjinM6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants