merge bitcoin#13671, #17405, #18786, #18792, #20067: Deboostification #4246
Conversation
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
13734 was already merged recently
18234 missing earlier scheduler related backports. This part is critical, would prefer to postpone it for now and backport them in the right order.
kwvg
force-pushed
the
deboostification
branch
3 times, most recently
from
aae814e to
52d7f81
Compare
kwvg
changed the title
There was a problem hiding this comment.
18792 should drop #include <boost/thread.hpp> in src/wallet/db.cpp like in the original PR. 18792 requires 17405 (which in its turn requires 11911) to be compilable (I hope), pls see https://github.com/UdjinM6/dash/commits/pr4246
EDIT: Hmm.. tests failed, so I guess smth else is missing (or maybe I backported them incorrectly)
|
TBH I would just prefer to maybe mark 18792 as partial and merge as is (unless either of you want to get that branch working) |
working on it :) |
|
Decided to backport 11911 in a separate PR #4263 since it's kind of unrelated to "deboostification". Once it's merged backporting 17405 and 18792 should be trivial. |
|
18792 originally dropped |
…uption_point fad1de6 wallet: Remove unused boost::this_thread::interruption_point (MarcoFalke) Pull request description: `BerkeleyEnvironment::Open` is only called from the main thread (init) or an http rpc thread, neither of which can be interrupted, so remove the useless interruption point. `BerkeleyEnvironment{}` is only used in tests, which run in a single process/thread, so remove the useless interruption point. ACKs for top commit: laanwj: ACK fad1de6 fanquake: ACK fad1de6 Tree-SHA512: dacd8398e966e4a6ce5cf7d3ed821c9c267eff40b14c0635085441647cdb72d1642807f89355419f1710f814c7963e35a10d102d0b985c7198261dfc736256f8
Co-authored-by: UdjinM6 <[email protected]>
UdjinM6
changed the title
4 participants
No description provided.