Skip to content

merge #16117, #18358, #17383, #21052, #14424, #15159, #14689, #14978, partial #16908, #14978, #13932: Auxillary Backports #4229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 11 commits into from
Aug 10, 2021
Merged

merge #16117, #18358, #17383, #21052, #14424, #15159, #14689, #14978, partial #16908, #14978, #13932: Auxillary Backports #4229

UdjinM6 merged 11 commits into from
Aug 10, 2021

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Jul 2, 2021 •
edited
Loading

Notes

bitcoin#20788 was originally having test failures and the lack of bitcoin#14624 was the cause. Tests run fine now. Scrapped from this PR

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 4, 2021

Windows build borked

@kwvg kwvg force-pushed the auxports branch 3 times, most recently from d47fe88 to f1ad65c Compare July 9, 2021 16:03
@kwvg
Copy link
Collaborator Author

kwvg commented Jul 9, 2021 •
edited
Loading

Rebased and updated

EDIT: Pushed version without nanobench fix, re-pushed correct version

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 9, 2021

Not compiling

UdjinM6
UdjinM6 requested changes Jul 10, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16908: missing changes in test/functional/mempool_persist.py
18358: see ebc239029c6e464c38cc1010755cfc387cef9a41
20788: lots of changes from other PRs

@kwvg kwvg force-pushed the auxports branch 2 times, most recently from aacf67c to 408c9e8 Compare July 13, 2021 10:30
@kwvg kwvg marked this pull request as draft July 13, 2021 10:35
@kwvg kwvg marked this pull request as ready for review July 13, 2021 14:27
@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 13, 2021

functional tests borked

@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Jul 14, 2021
@kwvg kwvg force-pushed the auxports branch 2 times, most recently from da10617 to 9657ce4 Compare July 15, 2021 17:57
@kwvg
Copy link
Collaborator Author

kwvg commented Jul 15, 2021

Dunno what's happening with functional tests so bitcoin#16908 has been slimmed to the bare essentials needed for successive commits

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 16, 2021

Needs rebase

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 17, 2021

Tests are failing

@github-actions
Copy link

github-actions bot commented Jul 19, 2021

This pull request has conflicts, please rebase.

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 28, 2021

Marking as WIP due to the fact this PR has stalled. Please rebase, and mark as ready for review when this PR is RfR

@PastaPastaPasta PastaPastaPasta marked this pull request as draft July 28, 2021 16:13
@kwvg kwvg changed the title merge #14624, #20788, #16117, #21052, partial #16908, #14978: Auxillary Backports merge #20788, #16117, #21052, partial #16908, #14978: Auxillary Backports Aug 1, 2021
@kwvg kwvg changed the title merge #20788, #16117, #21052, partial #16908, #14978: Auxillary Backports merge #16117, #18358, #17383, #21052, #14424, #15159, #14689, #14978, partial #16908, #14978, #13932: Auxillary Backports Aug 5, 2021
@kwvg kwvg marked this pull request as ready for review August 5, 2021 14:16
@kwvg
Copy link
Collaborator Author

kwvg commented Aug 5, 2021

Ready for review. Unrelated LLMQ tests failed

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Aug 5, 2021

Test failures in feature_llmq_data_recovery.py are persistent. Does not seem unrelated.

@kwvg
Copy link
Collaborator Author

kwvg commented Aug 5, 2021 •
edited
Loading

Test failures in feature_llmq_data_recovery.py are persistent. Does not seem unrelated.

Fixed, problem was isolated to 2659960 Apparently not.

EDIT: Integrated patches UdjinM6@781f6b9, UdjinM6@f37918a and UdjinM6@ada97ae by UdjinM6 have actually resolved the issue, thanks! 🙂

UdjinM6
UdjinM6 requested changes Aug 8, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see https://github.com/UdjinM6/dash/commits/pr4229

@kwvg kwvg requested a review from UdjinM6 August 9, 2021 07:09
UdjinM6
UdjinM6 approved these changes Aug 9, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 7aebf15 into dashpay:develop Aug 10, 2021
@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Aug 19, 2021
@dzutto dzutto mentioned this pull request Sep 11, 2021
Merged
@dzutto dzutto mentioned this pull request Sep 24, 2021
Merged
@kwvg kwvg deleted the auxports branch July 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta

Assignees

No one assigned

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

3 participants

@kwvg @PastaPastaPasta @UdjinM6