partial/logic backport #18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een 'filterload'..'filterclear') Previously, a default match-everything bloom filter was set for every peer, i.e. even before receiving a 'filterload' message and after receiving a 'filterclear' message code branches checking for the existence of the filter by testing the pointer "pfilter" were _always_ executed.
xdustinface
requested changes
Mar 18, 2021
xdustinface
left a comment
xdustinface
left a comment
There was a problem hiding this comment.
Any reason why you didn't do more like in the backport PR? Like in 2d73cdf
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 17, 2022
…n (active between 'filterload'..'filterclear') (dashpay#4043) * partial backport 18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') Previously, a default match-everything bloom filter was set for every peer, i.e. even before receiving a 'filterload' message and after receiving a 'filterclear' message code branches checking for the existence of the filter by testing the pointer "pfilter" were _always_ executed. * net: Match the backport PR a bit more Co-authored-by: xdustinface <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports bitcoin@5eae034
The original PR was merged into btc 0.21, so this "backports" logic, not code. Not backporting test changes because
p2p_filter.pytest simply does not exist in our code base yet, was introduced in btc 0.20.This is required for #4016 (which is how I found the issue) but even otherwise it's an actual bugfix e.g. for node eviction logic https://github.com/dashpay/dash/blob/develop/src/net.cpp#L1119.