Skip to content

wallet: Always skip conflicting txes in SelectCoinsGroupedByAddresses #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 2 commits into from
Feb 17, 2021
Merged

wallet: Always skip conflicting txes in SelectCoinsGroupedByAddresses #4002

PastaPastaPasta merged 2 commits into from
Feb 17, 2021

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 17, 2021

No description provided.

@UdjinM6 UdjinM6 added this to the 17 milestone Feb 17, 2021
xdustinface
xdustinface previously approved these changes Feb 17, 2021
View reviewed changes
Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Feb 17, 2021

How would you feel about a regression test? My understanding is this is a bug, no?

xdustinface
xdustinface approved these changes Feb 17, 2021
View reviewed changes
Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 1a61c5d into dashpay:develop Feb 17, 2021
@UdjinM6 UdjinM6 deleted the skip_conflicting branch July 1, 2021 21:58
@PastaPastaPasta PastaPastaPasta mentioned this pull request Oct 23, 2021
Merged
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 22, 2022
@UdjinM6 @gades
wallet: Always skip conflicting txes in SelectCoinsGroupedByAddresses (…
5530819 
…dashpay#4002)

* wallet: Always skip conflicting txes in SelectCoinsGroupedByAddresses

* tests: add tests for SelectCoinsGroupedByAddresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@xdustinface xdustinface xdustinface approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

17

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6 @PastaPastaPasta @xdustinface