Skip to content

Conversation

@xdustinface
Copy link

This is like #3937 (where this one is based on) also a preparation for the next coming PR which will use this encrypted contributions after DKG to share them with other members.

@PastaPastaPasta
Copy link
Member

Needs rebase (probably)

@xdustinface xdustinface force-pushed the pr-llmq-store-contributions branch from e1974ea to 7b7b3e4 Compare January 21, 2021 20:41
@xdustinface xdustinface marked this pull request as ready for review January 21, 2021 20:42
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Allows to store each member's encrypted contributions of the DKG.
I decided to don't cache here since its probably very unlikely this is called twice in a short period with what we have planed for it so far. We can add caching if the requirement for it changes at some point?
@xdustinface xdustinface force-pushed the pr-llmq-store-contributions branch from b51bb52 to e141a0d Compare January 22, 2021 12:52
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit ec1281c into dashpay:develop Jan 22, 2021
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 13, 2022
* llmq: Add CDKGSessionManager::WriteEncryptedContributions

Allows to store each member's encrypted contributions of the DKG.

* llmq: Store each member's contributions in the llmq database

* llmq: Add CDKGSessionManager::GetEncryptedContributions

I decided to don't cache here since its probably very unlikely this is called twice in a short period with what we have planed for it so far. We can add caching if the requirement for it changes at some point?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants