Skip to content

Conversation

@xdustinface
Copy link

No description provided.

@xdustinface xdustinface added the RPC Some notable changes to RPC params/behaviour/descriptions label Jan 12, 2021
@xdustinface xdustinface added this to the 17 milestone Jan 12, 2021
@PastaPastaPasta
Copy link
Member

Needs rebase

1 similar comment
@PastaPastaPasta
Copy link
Member

Needs rebase

@xdustinface xdustinface force-pushed the pr-rpc-getpeerinfo-mnauth branch from bb3b74c to 6a8b2d7 Compare January 21, 2021 18:48
@xdustinface xdustinface marked this pull request as ready for review January 21, 2021 18:48
UdjinM6
UdjinM6 previously approved these changes Jan 21, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo and minor wording change

@xdustinface xdustinface changed the title net|rpc: Add verified_pubkey_hash in getpeerinfo for MN connections net|rpc: getpeerinfo - Add verified_pubkey_hash, fix a typo in verified_proregtx_hash docs Jan 21, 2021
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests? terrible!

utACK

@PastaPastaPasta PastaPastaPasta merged commit 0c1a02b into dashpay:develop Jan 22, 2021
@xdustinface
Copy link
Author

no tests?

See #3930 (45a15fc) :D

gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 22, 2022
…ed_proregtx_hash docs (dashpay#3929)

* net|rpc: Add verified_pubkey_hash in getpeerinfo for MN connections

* Apply suggestions from code review

Co-authored-by: thephez <[email protected]>

* rpc: One more typo

Co-authored-by: thephez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants