Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 28, 2015

No description provided.

eduffield222 pushed a commit that referenced this pull request Jun 28, 2015
V0.12.0.x fix inputs lock - unlock inputs on DS failure
@eduffield222 eduffield222 merged commit d713be3 into dashpay:v0.12.0.x Jun 28, 2015
@UdjinM6 UdjinM6 deleted the v0.12.0.x_fix_inputs_lock branch July 17, 2015 10:32
knst pushed a commit to knst/dash that referenced this pull request Oct 25, 2024
62b125f qt, refactor: Fix indentation (Prateek Sancheti)
ad28b66 qt: Add SubFeeFromAmount option (Prateek Sancheti)

Pull request description:

  This PR adds **_SubFeeFromAmount_** option which lets the user select their preferred setting of whether fee for a transaction is to be subtracted from the amount or not for future transactions. The setting chosen by the user is remembered even when the GUI mode is turned off.

  **_Functionality and Usage:_**

  - Go to `Settings > Options > Wallet` on _Windows/Linux_ or `bitcoin-qt > Preferences > Wallet` on _macOS_.
  - The checkbox **Subtract Fee From Amount** corresponds to the added option **SubFeeFromAmount**.
  - The preferred setting intended to be the default for all future send transactions should be selected by the user.
  - Click on **OK**.
  - Go to the **Send** tab in the wallet.
  - You shall notice, any new Send transaction created will have the preferred setting as chosen by the user.<br> (Try clicking on Add recipient or even restarting the Node in GUI)

  Attaching ScreenRecordings to explain the added feature.

  > Master.mov: Master Branch

  https://user-images.githubusercontent.com/54016434/127763378-be91837d-d0ab-4ae5-87c0-d303fa70a336.mov

  > PR.mov: PullRequest

  https://user-images.githubusercontent.com/54016434/127763404-05b834c1-4082-4fbd-9b05-1528ac898a21.mov

  Close dashpay#386

ACKs for top commit:
  Talkless:
    tACK 62b125f, tested on Debian Sid with 5.15.2 and it works as described.
  hebasto:
    re-ACK 62b125f, only removed the unused `SubFeeFromAmountChanged` signal since my [previous](bitcoin-core/gui#390 (review)) review.
  meshcollider:
    utACK 62b125f

Tree-SHA512: 932ca89ae578a1e1c426561400d87cf005c231944feaf0f662ff8d88f32bdd65a927a090ea41510a15f8ec0ebcd5529672e9917720eb5ea85f413f081e45d5bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants