qt: Improved status bar #3688
Merged
qt: Improved status bar #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Greyed out HD doesn't seem super intuitive to me Otherwise, general concept ACK |
|
Yeah, the HD icon is kind of a pointless one for most users cause HD mode is disabled by default. Might be a good idea to just hide it if current wallet is a non-HD one (red HD icon would imply that smth is broken and users have to fix it but there is no way for them to do it). |
Author
|
Done, im glad you felt the same :D |
Disabling it leads to incorrect colors due to opacity.
Reason: Its the only one not turning green by default if all is set properly. So this lets is look better imo.
Just as signal to the user!
xdustinface
force-pushed
the
pr-ui-24-statusbar
branch
from
5dcec05 to
60d261d
Compare
Author
|
Rebased on develop |
|
I think you need to update HD icon here since this change was reverted in #3574 |
Author
|
good point haha |
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 12, 2020
* qt: Adjust green color * qt: Don't disable the HD icon Disabling it leads to incorrect colors due to opacity. * qt: Move the HD icon to the left Reason: Its the only one not turning green by default if all is set properly. So this lets is look better imo. * qt: Increase statusbar icon size * qt: Show lock icon in status bar also if wallet is not encrypted Just as signal to the user! * qt: Refine connection icon usage * qt: Use state related colors in statusbar * qt: Hide the HD icon for non-HD wallets * qt: Update HD icon
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
* qt: Adjust green color * qt: Don't disable the HD icon Disabling it leads to incorrect colors due to opacity. * qt: Move the HD icon to the left Reason: Its the only one not turning green by default if all is set properly. So this lets is look better imo. * qt: Increase statusbar icon size * qt: Show lock icon in status bar also if wallet is not encrypted Just as signal to the user! * qt: Refine connection icon usage * qt: Use state related colors in statusbar * qt: Hide the HD icon for non-HD wallets * qt: Update HD icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3574
General
The colors red, orange and green are used to signal different states of the icon's underlying functionalities. Like, green means just all good, orange is like a warning/kind of good/busy and red is danger/bad/disabled. I personally think that makes the status bar much more meaningful and it should be clear by intuition quickly what the stuff means when it's used. However, if you feel there is room for improvement let me know.
HD icon
hd_disabled.pngis not longer used (i have asset cleanup PR coming later so the icons stays in here with this PR). Instead the following rule applies:The grey disabled version was discussion in slack. But honestly i guess we should think one more time about this and either just hide the HD icon by default if no HD is enabled or give it a red HD icon if its not enabled just to follow the same line like with the other icons aka red == disabled and not mix the disabled state with red/grey. @UdjinM6 specifically pinging you at this point, i think you suggested the grey. Thoughts?
Sync icon
Encryption icon
Network icon
Best case
This is an example how a fully synced and encrypted HD wallet looks like before and now