Implement a safer version of GetCrashInfoFromException #3652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`abi::__cxa_current_exception_type()` can return `null`, handle this properly
PastaPastaPasta
requested changes
Aug 9, 2020
Co-authored-by: dustinface <[email protected]>
xdustinface
previously approved these changes
Aug 10, 2020
xdustinface
left a comment
xdustinface
left a comment
There was a problem hiding this comment.
utACK with an additional nit, just in case you still want to add it :)
Co-authored-by: dustinface <[email protected]>
xdustinface
approved these changes
Aug 13, 2020
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 23, 2020
* Implement a safer version of GetCrashInfoFromException `abi::__cxa_current_exception_type()` can return `null`, handle this properly * Update src/stacktraces.cpp Co-authored-by: dustinface <[email protected]> * Update src/stacktraces.cpp Co-authored-by: dustinface <[email protected]> Co-authored-by: dustinface <[email protected]>
Member
|
backported in #3670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abi::__cxa_current_exception_type()can returnnull, we should handle this properly