Skip to content

Conversation

@akshaynexus
Copy link

When doing a protx register_prepare it can be confusing to find out which address has no funds.This PR change shows the address where the funds are not available to make it simpler to find the addr to add funds to.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, one tiny suggestion

@UdjinM6 UdjinM6 added this to the 16 milestone Aug 4, 2020
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Edit: Actually we could still get rid of the sprintf there

"No funds at specified address " + EncodeDestination(fundDest)

@UdjinM6 UdjinM6 merged commit e542c49 into dashpay:develop Aug 9, 2020
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Aug 23, 2020
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Aug 26, 2020
@PastaPastaPasta
Copy link
Member

backported in #3670

gades pushed a commit to cosanta/cosanta-core that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants