More accurate fee/amount calculations in MakeCollateralAmounts #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2020
|
Sorry for not responding here for that long :D First i was distracted by LLMQs for a while, then i started to review/test here and while doing that i noticed that this PR at the end still doesn’t solve the initial issue. There are now even new cases introduced by this PR where unexpected transactions would pop up in the overview (e.g. if no change output is used and we only have one output). Actually i wanted to provide some fixes for this PR only but it turned out to be a bigger thing to make it totally right and then i ended up with #3657. |
Author
|
Closing in fav of #3657 |
Member
|
removing "backport" label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
MakeCollateralAmountsimplementation works incorrectly when fees are up. Which in its turn can cause issues like #3597. Adding fee calculations (instead of assumption thatGetCollateralAmount()duff fee should be enough) should do the trick IMO. This is basically the same logic we applied toCreateDenominatedin #3588.Another assumption we use is that
tallyItem.nAmountis enough to create at leastCPrivateSend::GetMaxCollateralAmount() - CPrivateSend::GetCollateralAmount()duff collateral which is not always true actually.Alternative to #3639