Fix -resetguisettings
#3624
Merged
Fix -resetguisettings
#3624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdustinface
approved these changes
Jul 21, 2020
xdustinface
left a comment
xdustinface
left a comment
There was a problem hiding this comment.
Haha nice, i noticed that a while ago but i somehow accepted it as a "feature" there! :D
Anyway, works now -> ACK!
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 23, 2020
Member
|
backported in #3670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
-resetguisettingsresults in settings being cleared not only on start but on shutdown too. The bug was introduced in #569 (5+ years ago 🙈 ). This should fix it by only setting the flag totruewhen the "Reset Options" button was clicked. I also renamedOptionsModel::resetSettingswhile at it to make it clearer what it's used for.