qt: Splashscreen redesign #3613
Conversation
- Make it theme related dark or light - Fixes bluriness issues - Fixes issues with overlapping init messages at the bottom of the splashscreen - Give it a cleaner look -> Removed copyrights and prefix `Version v` of the version string
xdustinface
force-pushed
the
pr-ui-23-splashscreen
branch
from
f066e6d to
73ac6a7
Compare
|
I'm kind of on the fence with this one... On one hand, I like it, looks much cleaner and reacts to theme changes but on the other hand, applying different colors to the logo kind of breaks the style guide I think (should be either Dash's blue or white, no other colors iirc). |
|
Hmm, i showed suba both new splashscreens and he approved them (orange one of testnet shouldn't matter for styleguide consistency imo). But i will ask him again what he thinks especially about coloring the icons this way! |
|
I talked to suba and we got the approval for this PR. The style guide will become adjusted in order to allow dark/light mode compatible blue dash logos and for testing usage there will be a new option to use the orange logo as we have it in here. Though, we still have regtest mode where we currently have a red logo with this PR. To minimize coloring of the logo and because its probably just not that important to have a seperate color for regtest we agreed on just using the same orange for all network modes other than mainnet, aka
@UdjinM6 thoughts? |
|
I'm not sure. Using a slightly different blue for the dark theme is fine IMO. But after playing with the orange one a bit I think using colors other than a blue-ish one (or white color like we currently do) for the logo is a bit too much. Also, I kind of like to have different tray icon colors for different networks. How about tweaking it like that https://github.com/UdjinM6/dash/commits/pr3613 instead? (the way I get these colors is a bit hack-ish but it does the job :) )
|
Hm yeah right.. actually its not even really needed to use an orange logo. Your alternative solution is good enough to highlight the other networks, picked it 👍
it is haha |
😄 Let's fix this, pls see e95b21c8d47a1b07ae9149b5cef6b628d9b8792f and 50f4813c35a7a88eb4c462e46d6c6bda752e0c7a |
Replaces the getTrayAndWindowIcon hack
|
Somehow it still doesn't feel final but i can't think about the ultimate solution right now.. i guess i would prefer to remove the color shift and just apply direct coloring to the icons but thats has also some drawbacks if icons change lol.. Anyway, your fix is still much better than the hack-ish one before, picked! 😄 |
* qt: Splashscreen redesign - Make it theme related dark or light - Fixes bluriness issues - Fixes issues with overlapping init messages at the bottom of the splashscreen - Give it a cleaner look -> Removed copyrights and prefix `Version v` of the version string * Do not rotate colors of the splash image * Adjust logo color based on the current theme for all networks * Draw network-specific text as a "badge" with a network-specific color * Introduce `NetworkStyle::rotateColor()` helper * Introduce badge color in NetworkStyle and use it in SplashScreen's ctor Replaces the getTrayAndWindowIcon hack * refactor loops Co-authored-by: UdjinM6 <[email protected]>
* qt: Splashscreen redesign - Make it theme related dark or light - Fixes bluriness issues - Fixes issues with overlapping init messages at the bottom of the splashscreen - Give it a cleaner look -> Removed copyrights and prefix `Version v` of the version string * Do not rotate colors of the splash image * Adjust logo color based on the current theme for all networks * Draw network-specific text as a "badge" with a network-specific color * Introduce `NetworkStyle::rotateColor()` helper * Introduce badge color in NetworkStyle and use it in SplashScreen's ctor Replaces the getTrayAndWindowIcon hack * refactor loops Co-authored-by: UdjinM6 <[email protected]>
3 participants
This PR ist part of a series of PRs related to UI redesigns. Its ancestor is #3575.
I hope that no one has a good reason to keep the copyrights on the splashscreen because i removed them in this PR. I thought it's enough to have them presented in the "About Dialog". If you see any problem with it let me know but i felt like i need to try it because it just looks much cleaner :)
Changes of this PR
splashscreen
Version vof the version string