Skip to content

Conversation

@PastaPastaPasta
Copy link
Member

No description provided.

@PastaPastaPasta PastaPastaPasta force-pushed the prune-param-interaction branch 2 times, most recently from 1068beb to c701916 Compare July 6, 2020 03:04
@PastaPastaPasta PastaPastaPasta force-pushed the prune-param-interaction branch from c701916 to 1591ffc Compare July 6, 2020 03:05
@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review July 6, 2020 03:05
@PastaPastaPasta PastaPastaPasta requested a review from UdjinM6 July 6, 2020 03:05
@PastaPastaPasta
Copy link
Member Author

Ready for review. This should make it easier for people to run a pruned node. If someone starts with -prune core will automatically try to set txindex and disablegovernance to the proper values, and will abort if not possible. It still shows the "governance validation is disabled" message but I made it a bit less scary. In the future I plan on changing it so that that warning will only pop up if it's a users first time in pruned mode, or if they aren't in pruned mode but have governance validation disabled.

@UdjinM6
Copy link

UdjinM6 commented Jul 6, 2020

Pls see https://github.com/UdjinM6/dash/commits/pr3579:

  • 34f5c1508ce17e9c946972165800ccb7a039cb11 is needed to ensure consistency of newly added checks/assignment of -disablegovernance
  • 1d0d61df8a4eb87ec498fc636bf95f0f2e755859 is a cleanup, this logic really belongs to AppInitParameterInteraction
  • b2bb2649ee2e557adada59b975d620fcfef535bf is needed to fix blockchain.py and it's actually ok to skip this warning on pruned nodes completely, see inline comments
  • 57dbd7748670cb0626aaa15f6d07b07cfb806e53 trivial text tweaks

@PastaPastaPasta
Copy link
Member Author

I generally disagree with b2bb2649ee2e557adada59b975d620fcfef535bf because it is still important for pruned node operators to realize that they aren't doing FULL validation, only mostly full validation. I want in the future that warning to only pop up in case of first launch prune or launching w/o prune

@UdjinM6
Copy link

UdjinM6 commented Jul 6, 2020

Well, then you need smth like 97e0fafcaa for example cause blockchain.py fails because of this warning atm.

@PastaPastaPasta
Copy link
Member Author

done

@UdjinM6 UdjinM6 added this to the 16 milestone Jul 6, 2020
@UdjinM6
Copy link

UdjinM6 commented Jul 6, 2020

Hmm... looks like more changes are needed to fix tests, pls see 4e9dfe90bb

@PastaPastaPasta
Copy link
Member Author

commited suggestion

@PastaPastaPasta
Copy link
Member Author

cherry-picked

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit d5c5953 into dashpay:develop Jul 8, 2020
@PastaPastaPasta PastaPastaPasta deleted the prune-param-interaction branch July 8, 2020 23:34
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Aug 23, 2020
* explicitly check that -disablegovernance is true for pruned mode.

Signed-off-by: pasta <[email protected]>

* try to set -disablegovernance and -txindex if pruned mode is enabled

Signed-off-by: pasta <[email protected]>

* Adjust InitWarning when governance validation is disabled

Signed-off-by: pasta <[email protected]>

* Check for deprecated -litemode earlier

* Move -disablegovernance warning into AppInitParameterInteraction

* Tweak -prune help text and a related comment in AppInitParameterInteraction

* Ignore init warnings in blockchain.py

* Adjust "governance validation disabled" warning depending on if running a pruned node

Co-authored-by: UdjinM6 <[email protected]>

* Skip init warnings in import-rescan.py and node_network_limited.py

Co-authored-by: UdjinM6 <[email protected]>
@PastaPastaPasta
Copy link
Member Author

backported in #3670

gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 8, 2022
* explicitly check that -disablegovernance is true for pruned mode.

Signed-off-by: pasta <[email protected]>

* try to set -disablegovernance and -txindex if pruned mode is enabled

Signed-off-by: pasta <[email protected]>

* Adjust InitWarning when governance validation is disabled

Signed-off-by: pasta <[email protected]>

* Check for deprecated -litemode earlier

* Move -disablegovernance warning into AppInitParameterInteraction

* Tweak -prune help text and a related comment in AppInitParameterInteraction

* Ignore init warnings in blockchain.py

* Adjust "governance validation disabled" warning depending on if running a pruned node

Co-authored-by: UdjinM6 <[email protected]>

* Skip init warnings in import-rescan.py and node_network_limited.py

Co-authored-by: UdjinM6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants