qt: Update assets and colorize them theme related #3574

xdustinface · 2020-06-26T14:12:52Z

This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3573, its successor is #3575. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.

-> Walk through 0.15
-> Walk through Redesign

I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.

About this PR

Replaces all checkbox and radiobutton assets with new ones aligned with the css style changes
Brings some changes to the usage of the arrows.
Updates all icons (at least all that will be still used after my next few PRs)
Updates the spinner
Makes sure icons are updated to the correct theme color if the theme gets changed
Adds GUIUtil::getIcon and GUIUtil::setIcon methods. They allow to colorize two colored icons.. Ideally those colors should be just black 0x000000 or white 0xFFFFFF. But the methods fill everything below 0x7F7F7F with the first color provided and the other part with the alternative color provided. So you can either get themed colored icons or directly set one for QAbtractButton derivations.

Preview

Send Dark: develop	Send Dark: After

Console Dark: develop	Console Dark: After

Send Light: develop	Send Light: After

Console Light: develop	Console Light: After

- Removed "hover" arrows - Rename normal -> light - Rename pressed -> dark - Use light as hover in dark theme and vice versa

- ThemedColor::ORANGE - ThemedColor::ICON_ALTERNATIVE_COLOR

Instead of QPushButton. This is to have the same alignment of the iconized buttons by default like in SendCoinsEntry

xdustinface · 2020-09-06T19:15:43Z

Ready for review! I updated the initial post with some description and screenshots.

PastaPastaPasta · 2020-09-07T05:15:47Z

I'm not a fan of the new "send/receive/send to self" icons.

I also don't like the HD logo

Otherwise looks good

xdustinface · 2020-09-07T08:00:00Z

I'm not a fan of the new "send/receive/send to self" icons.

Me neither, at least for the transaction screen. But they will be removed from there anyway in a follow up PR. I just did them this way for the debug console, there were the same ones used. But overall i think i will also drop them from there because i didn't find a way yet to align them properly with the increasing/decreasing text... So you may not longer need to look at them soon anyway :D

I also don't like the HD logo

I also partially share that with you, but only for hd_disabled.. and to be honest, i didn't put a lot love into this because i want to remove it anyway with #3688.. just created it for this PR to have it similar to the new hd_enabled.

UdjinM6 · 2020-09-08T10:59:56Z

Agree with @PastaPastaPasta re some new icons (hd/sent/received/to_self), would rather keep the old ones for now and replace/drop them when we are ready.

xdustinface · 2020-09-09T03:26:35Z

Okay i reverted the arrows. But regarding the HD icon i don't get it :D Look at the following.. does it really make sense to move it out of this PR now? IMO the old one doesn't fit any better in there.. rather worse since its smaller. Still want to revert it, let me know

HD enabled before	HD enabled now

HD disabled before	HD disabled now

UdjinM6 · 2020-09-09T11:42:01Z

Well, it's actually easier to say if it's a HD wallet or not looking at the smaller one imo.

xdustinface · 2020-09-09T13:19:49Z

Soo there we go, i still don't like its since its kind of pointless after the statusbar PR and i actually wanted to update all icons in one PR but what should i say if you both feel different 😄

UdjinM6

ACK

PastaPastaPasta

utACK, tested an earlier version.

* qt: Replaced checkbox images with new ones * qt: Replaced radiobutton images with new ones * qt: Redefine arrow usage - Removed "hover" arrows - Rename normal -> light - Rename pressed -> dark - Use light as hover in dark theme and vice versa * qt: Update icon set * qt: Update sync spinner * qt: Add new ThemedColor's - ThemedColor::ORANGE - ThemedColor::ICON_ALTERNATIVE_COLOR * qt: Add GUIUtil::getIcon and GUIUtil::setIcon * qt: Use themed icons where required * qt: Make sure icons in SendCoinsEntry are updated on style changes * qt: Make sure status bar icons are updated on style changes * qt: Make sure icons in RPCConsole are updated on style changes * qt: Remove icon/iconsSize in modaloverlaydialog.ui * qt: Remove obsolete qproperty-iconSize entries from general.css * qt: Use QToolButton's in SendVerifyMessageDialog and RPCConsole Instead of QPushButton. This is to have the same alignment of the iconized buttons by default like in SendCoinsEntry * qt: Revert arrow icons * qt: Revert HD icons

28f8b66 Diagnose unsuitable outputs in lockunspent(). (Eelis) Pull request description: Fixes dashpay#2667. This is a simplified version of pull request dashpay#3574, which was abandoned by its author. I added some tests as well. Tree-SHA512: e63e00dec8b1b232079380183805cb0b0b18c78ea6bea769837949aab984689d7f68b2ccfe66b1873517b040b9e616ce0eb058575c3d4382aa8c26eebcf1f14e

This was referenced Jun 26, 2020

qt: Add missing placeholders #3575

Merged

qt: Drop PlatformStyle #3573

Merged

xdustinface force-pushed the pr-ui-21-assets branch 2 times, most recently from 04353b1 to d64f5f5 Compare June 27, 2020 20:24

xdustinface marked this pull request as draft June 30, 2020 20:25

xdustinface mentioned this pull request Sep 1, 2020

qt: Backport UI redesign to v0.16.x #3684

Merged

xdustinface added 5 commits September 5, 2020 23:04

qt: Replaced checkbox images with new ones

4e3ef1b

qt: Replaced radiobutton images with new ones

897c34f

qt: Redefine arrow usage

f7f7aa0

- Removed "hover" arrows - Rename normal -> light - Rename pressed -> dark - Use light as hover in dark theme and vice versa

qt: Update icon set

a73d5dc

qt: Update sync spinner

806d041

xdustinface force-pushed the pr-ui-21-assets branch from d64f5f5 to 3656153 Compare September 6, 2020 18:48

xdustinface changed the title ~~qt: Update some assets~~ qt: Update assets and colorize them theme related Sep 6, 2020

xdustinface added 9 commits September 6, 2020 21:07

qt: Add new ThemedColor's

b6ca6cb

- ThemedColor::ORANGE - ThemedColor::ICON_ALTERNATIVE_COLOR

qt: Add GUIUtil::getIcon and GUIUtil::setIcon

4a0c953

qt: Use themed icons where required

7bd2c36

qt: Make sure icons in SendCoinsEntry are updated on style changes

88e2dd0

qt: Make sure status bar icons are updated on style changes

94d7876

qt: Make sure icons in RPCConsole are updated on style changes

16a56a6

qt: Remove icon/iconsSize in modaloverlaydialog.ui

81200ed

qt: Remove obsolete qproperty-iconSize entries from general.css

aaf681e

qt: Use QToolButton's in SendVerifyMessageDialog and RPCConsole

31096a1

Instead of QPushButton. This is to have the same alignment of the iconized buttons by default like in SendCoinsEntry

xdustinface force-pushed the pr-ui-21-assets branch from 3656153 to 31096a1 Compare September 6, 2020 19:08

xdustinface marked this pull request as ready for review September 6, 2020 19:15

xdustinface mentioned this pull request Sep 7, 2020

qt: Improved status bar #3688

Merged

qt: Revert arrow icons

a29ba9e

PastaPastaPasta added the backport-candidate-16.x label Sep 9, 2020

PastaPastaPasta added this to the 16 milestone Sep 9, 2020

qt: Revert HD icons

072a8ec

UdjinM6 approved these changes Sep 10, 2020

View reviewed changes

PastaPastaPasta approved these changes Sep 10, 2020

View reviewed changes

UdjinM6 merged commit c7a9f47 into dashpay:develop Sep 10, 2020

UdjinM6 removed the backport-candidate-16.x label Sep 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

qt: Update assets and colorize them theme related #3574

qt: Update assets and colorize them theme related #3574

Uh oh!

xdustinface commented Jun 26, 2020 •

edited

Loading

Uh oh!

xdustinface commented Sep 6, 2020

Uh oh!

PastaPastaPasta commented Sep 7, 2020

Uh oh!

xdustinface commented Sep 7, 2020

Uh oh!

UdjinM6 commented Sep 8, 2020 •

edited

Loading

Uh oh!

xdustinface commented Sep 9, 2020

Uh oh!

UdjinM6 commented Sep 9, 2020

Uh oh!

xdustinface commented Sep 9, 2020

Uh oh!

UdjinM6 left a comment

Uh oh!

PastaPastaPasta left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qt: Update assets and colorize them theme related #3574

qt: Update assets and colorize them theme related #3574

Uh oh!

Conversation

xdustinface commented Jun 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About this PR

Preview

Uh oh!

xdustinface commented Sep 6, 2020

Uh oh!

PastaPastaPasta commented Sep 7, 2020

Uh oh!

xdustinface commented Sep 7, 2020

Uh oh!

UdjinM6 commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xdustinface commented Sep 9, 2020

Uh oh!

UdjinM6 commented Sep 9, 2020

Uh oh!

xdustinface commented Sep 9, 2020

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xdustinface commented Jun 26, 2020 •

edited

Loading

UdjinM6 commented Sep 8, 2020 •

edited

Loading