qt: Add -custom-css-dir commmand line parameter #3557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2020
xdustinface
force-pushed
the
pr-ui-4-custom-css
branch
2 times, most recently
from
b6af742 to
28ae550
Compare
Required for the introduction of a custom css directory which will happen with the follow-up commits.
xdustinface
force-pushed
the
pr-ui-4-custom-css
branch
from
28ae550 to
9acce41
Compare
Author
|
ready for review |
xdustinface
force-pushed
the
pr-ui-4-custom-css
branch
4 times, most recently
from
4219d60 to
3030216
Compare
Author
|
Those force pushes were mostly only to figure how to reorder the commits in here properly because the order was messed. Now they appear in the correct order. One did change the command line description a bit. |
UdjinM6
requested changes
Jul 10, 2020
xdustinface
force-pushed
the
pr-ui-4-custom-css
branch
from
3030216 to
4e0735f
Compare
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
One comment, haven't tested, overall looks fine
src/qt/dash.cpp
Outdated
Member
There was a problem hiding this comment.
Why the double new line?
Author
There was a problem hiding this comment.
To get a bit space before the list of missing files. Thanks for asking haven't tested that for a while and it now realised that i messed with it over the time, will force push soon.
This allows to load a custom directory as css directory. The custom directory currently needs to have the files: - general.css - dark.css - light.css - traditional.css - scrollbars.css
xdustinface
force-pushed
the
pr-ui-4-custom-css
branch
from
4e0735f to
b63d661
Compare
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: Change themes path from ":themes" to ":css" Required for the introduction of a custom css directory which will happen with the follow-up commits. * qt: Renamed trad.css to traditional.css * qt: Add -custom-css-dir startup parameter This allows to load a custom directory as css directory. The custom directory currently needs to have the files: - general.css - dark.css - light.css - traditional.css - scrollbars.css
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
* qt: Change themes path from ":themes" to ":css" Required for the introduction of a custom css directory which will happen with the follow-up commits. * qt: Renamed trad.css to traditional.css * qt: Add -custom-css-dir startup parameter This allows to load a custom directory as css directory. The custom directory currently needs to have the files: - general.css - dark.css - light.css - traditional.css - scrollbars.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3556, its successor is #3558. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
This PR allows to load a custom directory as css directory. The css files in the provided directory will be used as stylesheets for the UI instead of the app internal ones.